Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipam: use ip provided by nad annotation when providing IPAM for other CNI plugins #4883

Merged
merged 1 commit into from
Dec 30, 2024
Merged

ipam: use ip provided by nad annotation when providing IPAM for other CNI plugins #4883

merged 1 commit into from
Dec 30, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12542229423

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.088%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/pod.go 0 4 0.0%
Totals Coverage Status
Change from base Build 12540700781: 0.0%
Covered Lines: 10160
Relevant Lines: 45997
💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 30, 2024 06:30
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 30, 2024
@dosubot dosubot bot added the enhancement Improve exist functions label Dec 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2024
@zhangzujian zhangzujian merged commit d10251f into kubeovn:master Dec 30, 2024
67 of 68 checks passed
@zhangzujian zhangzujian deleted the update-multus-e2e branch December 30, 2024 06:41
zhangzujian added a commit that referenced this pull request Dec 31, 2024
@zhangzujian
ipam: use ip provided by nad annotation when providing IPAM for other…
5d787e2 
… CNI plugins (#4883)

Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
enhancement Improve exist functions lgtm This PR has been approved by a maintainer need backport size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzujian @coveralls @oilbeater