-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kubevirt/pkg/controller dependency #4933
Open
xrstf
wants to merge
5
commits into
kubeovn:master
Choose a base branch
from
xrstf:remove-kubevirt-ctrl-dependency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13014792021Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@xrstf the conflict need to be resolved. |
9d294a3
to
87a33c1
Compare
Signed-off-by: Christoph Mewes <[email protected]>
Signed-off-by: Christoph Mewes <[email protected]>
Signed-off-by: Christoph Mewes <[email protected]>
Signed-off-by: Christoph Mewes <[email protected]>
Signed-off-by: Christoph Mewes <[email protected]>
87a33c1
to
019d6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
By importing
kubevirt.io/kubevirt
, KubeOVN also has to import and deal with an incredible amount of legacy cruft. Compared tokubevirt.io/api
, the Go dependencies of the main kubevirt module are not so very much up-to-date.KubeOVN only uses a single struct from the kubevirt codebase, and of that struct just very little. I propose that it is cheaper and in the long-term more maintainable to copy-paste the required code into this repository. This gets rid of the heavy dependency and quite a few
replace
directives. This in turn helps other projects that import KubeOVN into their codebase.Since both projects are Apache Licensed, I would consider this an okay-ish hack with more upsides than downsides.