Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use httpGet as liveness/readiness probe method #4945

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jan 24, 2025

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

In some environments, liveness/readiness probe by exec fails occasionally while tcpSocket always succeeds. The failure may be caused by `containerd but we have no evidence.

When secure serving is enabled, a plain tcp connection (without TLS) will cause an EOF error in the pod logs. So we need to use httpGet.

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 13191039291

Details

  • 0 of 34 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 22.323%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/health_check.go 0 7 0.0%
pkg/metrics/server.go 0 27 0.0%
Totals Coverage Status
Change from base Build 13190116688: -0.01%
Covered Lines: 10376
Relevant Lines: 46482

💛 - Coveralls

@zhangzujian zhangzujian force-pushed the fix-hc branch 3 times, most recently from 97b399c to c4e8a42 Compare February 6, 2025 09:35
@zhangzujian zhangzujian changed the title split kube-ovn-healthcheck into separate binary use httpGet as liveness/readiness probe method Feb 6, 2025
@zhangzujian zhangzujian marked this pull request as ready for review February 6, 2025 09:36
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement Improve exist functions labels Feb 6, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian merged commit 57b3733 into kubeovn:master Feb 7, 2025
67 of 68 checks passed
@zhangzujian zhangzujian deleted the fix-hc branch February 7, 2025 02:13
zhangzujian added a commit that referenced this pull request Feb 7, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit that referenced this pull request Feb 8, 2025
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve exist functions need backport size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants