-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing method invocation in kube_config_test.py #2272
fix: missing method invocation in kube_config_test.py #2272
Conversation
fix missing method invocation
The committers listed above are authorized under a signed CLA. |
Welcome @kavishdahekar! |
/assign @yliaog |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kavishdahekar, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
test_load_kube_config_from_dict_with_temp_file_path
test calls_cleanup_temp_files
without invoking it_cleanup_temp_files()
. This PR fixes that.Which issue(s) this PR fixes:
Fixes n/a
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: