update volumegroupsnapshot to beta1 #612
Conversation
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
cncf-cla: yes
|
/assign @xing-yang |
|
/release-note-none |
k8s-ci-robot
added
release-note-none
| ``` | ||
|
|
||
| Create a _PVC_ from a _VolumeSnapshot_ that is part of the group snapshot: | ||
| ``` | ||
| # In the command below, the volume snapshot name should be chosen from | ||
| # the ones listed in the output of the previous command | ||
| sed 's/new-snapshot-demo-v1/snapshot-4bcc4a322a473abf32babe3df5779d14349542b1f0eb6f9dab0466a85c59cd42-2024-06-19-12.35.17/' restore.yaml | kubectl create -f - | ||
| sed 's/new-snapshot-demo-v1/snapshot-4dc1c53a29538b36e85003503a4bcac5dbde4cff59e81f1e3bb80b6c18c3fd03/' restore.yaml | kubectl create -f - |
There was a problem hiding this comment.
@Madhu-1, the object name new-snapshot-demo-v1 is missing in the docs. The docs didn't mention how it is applied here.
I noticed that it references this file.
I am trying to replicate the example and I am having trouble restoring my actual snapshot. I think something may be missing, but I don't know what.
There was a problem hiding this comment.
I just realized that it replaces the dataSource name in the restore.yaml file with that of the snapshot.
There was a problem hiding this comment.
yes this is sed to replace the name in the restore.yaml from the repo
Madhu-1
force-pushed
the
update-csi-snap-restore-doc
branch
from
e2fd2ee to
2302321
Compare
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| Status | Min K8s Version | Max K8s Version | snapshot-controller Version | snapshot-validation-webhook Version | CSI external-snapshotter sidecar Version | external-provisioner Version | |||
| --|--|--|--|--|--|-- | |||
| Alpha | 1.27 | - | 7.0+ | 7.0+ | 7.0+ | 4.0+ | |||
| Alpha | 1.27 | 1.32 | 7.0+ | 7.0+ | 7.0+ | 4.0+ | |||
| Beta | 1.32 | - | 8.2+ | 8.2+ | 8.2+ | 4.0+ | |||
There was a problem hiding this comment.
Can you update the provisioner version to the latest which is 5.1.0?
There was a problem hiding this comment.
added 5.1+. as the same format is followed for other versions. let me know if need to be updated to have 5.1.0
There was a problem hiding this comment.
Yes, please update other places to be consistent.
updating the volumegroupsnapshot to beta1 API
Madhu-1
force-pushed
the
update-csi-snap-restore-doc
branch
from
2302321 to
fbb0eb7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
updating the volumegroupsnapshot to beta1 API