Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow accepting self-hosted gitlab installations #706

Merged
merged 1 commit into from
Feb 6, 2025
Merged

✨ Allow accepting self-hosted gitlab installations #706

merged 1 commit into from
Feb 6, 2025
+9 −3

Conversation

ts-mini
Copy link
Contributor

@ts-mini ts-mini commented Jan 30, 2025

What this PR does / why we need it: The current implementation of the gitlab check uses HasPrefix - which doesn't allow for a gitlab whose domain could be different (gitlab-example.domain.com)

Which issue(s) this PR fixes:
Fixes #705

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ts-mini. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 63b6f1f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/679d124d6d5dec0008e19302
😎 Deploy Preview https://deploy-preview-706--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ts-mini ts-mini force-pushed the tsmini.support-any-gitlab branch from aef8fda to 9f3099d Compare January 30, 2025 23:25
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2025
@ts-mini ts-mini force-pushed the tsmini.support-any-gitlab branch 2 times, most recently from c29d9f1 to 90d55ab Compare January 31, 2025 18:08
@ts-mini ts-mini force-pushed the tsmini.support-any-gitlab branch from 90d55ab to 63b6f1f Compare January 31, 2025 18:11
@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
alexander-demicev
alexander-demicev approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@furkatgofurov7
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35686f6620c4a71138cf90e1bca9dc5b953d95da

@furkatgofurov7
Copy link
Member

/retitle ✨ Allow accepting self-hosted gitlab installations

@k8s-ci-robot k8s-ci-robot changed the title ✨ gitlab fetchConfig regexp ✨ Allow accepting self-hosted gitlab installations Feb 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit bfcacce into kubernetes-sigs:main Feb 6, 2025
16 checks passed
@ts-mini ts-mini deleted the tsmini.support-any-gitlab branch February 6, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@dmvolod dmvolod dmvolod left review comments

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster API fetchConfig accepting self-hosted gitlab installations
5 participants
@ts-mini @k8s-ci-robot @furkatgofurov7 @alexander-demicev @dmvolod