Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Enable NSX LB healthcheck on kube-apiserver #3128

Merged
merged 3 commits into from
Aug 26, 2024
Merged

✨ Enable NSX LB healthcheck on kube-apiserver #3128

merged 3 commits into from
Aug 26, 2024

Conversation

DanielXiao
Copy link
Contributor

@DanielXiao DanielXiao commented Jul 31, 2024 •
edited
Loading

In the VPC network, the vm-operator Pod and Kubernetes Clusters are in different VPCs. TCP readiness probe does not work across VPC so use LB 's healthcheck instead. This annotation is agnostic to LB providers. NSX LB supports it to enable healthcheck while AVI LB has healthcheck enabled by default. vm-operator will propagate this annotation to Service annotation.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot requested review from chrischdi and yastij July 31, 2024 06:57
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@DanielXiao DanielXiao mentioned this pull request Jul 31, 2024
Open
@sbueringer
Copy link
Member

Looks good so far

@sbueringer sbueringer added this to the v1.11 milestone Aug 1, 2024
@DanielXiao DanielXiao force-pushed the nsx-lb-healthcheck branch 2 times, most recently from 2cb0f80 to 8b4d7fe Compare August 16, 2024 05:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@DanielXiao
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-verify-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2024
@DanielXiao
Enable NSX LB healthcheck on kube-apiserver
c12d47a 
In the VPC network, the vm-operator Pod and Kubernetes
Clusters are in different VPCs. TCP readiness probe does
not work across VPC. Use LB 's healthcheck instead. This
annotation is agnostic to LB providers. NSX LB supports
it to enable healthcheck while AVI LB has healthcheck
enabled by default.
@DanielXiao
Update nsx-operator API mod
fd7ae02 
There is a group refactor in nsx-operator API, so we need to
update to latest version.
@DanielXiao DanielXiao changed the title ✨ WIP:Enable NSX LB healthcheck on kube-apiserver ✨ Enable NSX LB healthcheck on kube-apiserver Aug 26, 2024
chrischdi
chrischdi reviewed Aug 26, 2024
View reviewed changes
go.mod Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 26, 2024
View reviewed changes
pkg/manager/manager.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
pkg/services/network/network_test.go Outdated Show resolved Hide resolved
pkg/services/network/nsxt_vpc_provider.go Show resolved Hide resolved
pkg/services/network/nsxt_vpc_provider.go Outdated Show resolved Hide resolved
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 26, 2024
@sbueringer
Copy link
Member

/lgtm
/approve

/hold
@chrischdi Let's merge?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@sbueringer
Copy link
Member

/cherry-pick release-1.11

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69ba92d72cccc3b8df385dc4a7bf68a1f720aee6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 46b9b9c into kubernetes-sigs:main Aug 26, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.11, v1.12 Aug 26, 2024
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 26, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #3170

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@yastij yastij Awaiting requested review from yastij

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielXiao @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot @chrischdi