Fix golint errors

gwctl/cmd/describe.go

@@ -95,7 +95,7 @@ func runDescribe(cmd *cobra.Command, args []string, params *utils.CmdParams) {
 			}
 		}
 		policiesPrinter.PrintPoliciesDescribeView(policyList)
-	
+
 	case "policycrd", "policycrds":
 		var policyCrdList []policymanager.PolicyCRD
 		if len(args) == 1 {

gwctl/pkg/common/clients.go

@@ -30,6 +30,7 @@ import (
 	"k8s.io/client-go/tools/clientcmd"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	fakeclient "sigs.k8s.io/controller-runtime/pkg/client/fake"
+
 	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
 	gatewayv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
 	gatewayv1beta1 "sigs.k8s.io/gateway-api/apis/v1beta1"
@@ -51,9 +52,15 @@ func NewK8sClients(kubeconfig string) (*K8sClients, error) {
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Kubernetes client: %v", err)
 	}
-	gatewayv1alpha2.AddToScheme(client.Scheme())
-	gatewayv1beta1.AddToScheme(client.Scheme())
-	gatewayv1.AddToScheme(client.Scheme())
+	if err := gatewayv1alpha2.AddToScheme(client.Scheme()); err != nil {
+		return nil, err
+	}
+	if err := gatewayv1beta1.AddToScheme(client.Scheme()); err != nil {
+		return nil, err
+	}
+	if err := gatewayv1.AddToScheme(client.Scheme()); err != nil {
+		return nil, err
+	}
 
 	dc := dynamic.NewForConfigOrDie(restConfig)
 
@@ -66,10 +73,18 @@ func NewK8sClients(kubeconfig string) (*K8sClients, error) {
 
 func MustClientsForTest(t *testing.T, initRuntimeObjects ...runtime.Object) *K8sClients {
 	scheme := scheme.Scheme
-	gatewayv1alpha2.AddToScheme(scheme)
-	gatewayv1beta1.AddToScheme(scheme)
-	gatewayv1.AddToScheme(scheme)
-	apiextensionsv1.AddToScheme(scheme)
+	if err := gatewayv1alpha2.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
+	if err := gatewayv1beta1.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
+	if err := gatewayv1.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
+	if err := apiextensionsv1.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
 
 	fakeClient := fakeclient.NewClientBuilder().WithScheme(scheme).WithRuntimeObjects(initRuntimeObjects...).Build()
 	fakeDC := fakedynamicclient.NewSimpleDynamicClient(scheme, initRuntimeObjects...)

gwctl/pkg/policymanager/manager.go

@@ -28,6 +28,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/client-go/dynamic"
+
 	gatewayv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
 )
 
@@ -67,7 +68,9 @@ func (p *PolicyManager) Init(ctx context.Context) error {
 		return err
 	}
 	for _, unstrucutredPolicy := range allPolicies {
-		p.AddPolicy(unstrucutredPolicy)
+		if err := p.AddPolicy(unstrucutredPolicy); err != nil {
+			return err
+		}
 	}
 
 	return nil

gwctl/pkg/policymanager/merger.go

@@ -192,7 +192,6 @@ func orderPolicyByPrecedence(a, b Policy) (Policy, Policy) {
 		if higherNN > lowerNN {
 			higherPolicy, lowerPolicy = lowerPolicy, higherPolicy
 		}
-
 	} else if higherPolicy.u.GetCreationTimestamp().Time.After(lowerPolicy.u.GetCreationTimestamp().Time) {
 		// Policies have difference creation time, so this will decide the precedence
 		higherPolicy, lowerPolicy = lowerPolicy, higherPolicy

gwctl/pkg/printer/gatewayclasses.go

@@ -19,21 +19,20 @@ package printer
 import (
 	"fmt"
 	"io"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/utils/ptr"
 	"os"
-	v1 "sigs.k8s.io/gateway-api/apis/v1"
 	"sort"
 	"strings"
 	"text/tabwriter"
 
-	"sigs.k8s.io/yaml"
-
+	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/policymanager"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/resourcediscovery"
 
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/duration"
 	"k8s.io/utils/clock"
+	"k8s.io/utils/ptr"
+	"sigs.k8s.io/yaml"
 )
 
 type GatewayClassesPrinter struct {
@@ -54,14 +53,18 @@ type gatewayClassDescribeView struct {
 	// GatewayClass description
 	Description *string `json:",omitempty"`
 
-	Status                   *v1.GatewayClassStatus `json:",omitempty"`
-	DirectlyAttachedPolicies []policymanager.ObjRef `json:",omitempty"`
+	Status                   *gatewayv1.GatewayClassStatus `json:",omitempty"`
+	DirectlyAttachedPolicies []policymanager.ObjRef        `json:",omitempty"`
 }
 
 func (gcp *GatewayClassesPrinter) Print(model *resourcediscovery.ResourceModel) {
 	tw := tabwriter.NewWriter(gcp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAME", "CONTROLLER", "ACCEPTED", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	gatewayClassNodes := make([]*resourcediscovery.GatewayClassNode, 0, len(model.GatewayClasses))
 	for _, gatewayClassNode := range model.GatewayClasses {
@@ -91,7 +94,11 @@ func (gcp *GatewayClassesPrinter) Print(model *resourcediscovery.ResourceModel)
 			accepted,
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }

gwctl/pkg/printer/gateways.go

@@ -26,10 +26,10 @@ import (
 
 	"sigs.k8s.io/gateway-api/gwctl/pkg/policymanager"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/resourcediscovery"
-	"sigs.k8s.io/yaml"
 
 	"k8s.io/apimachinery/pkg/util/duration"
 	"k8s.io/utils/clock"
+	"sigs.k8s.io/yaml"
 )
 
 type GatewaysPrinter struct {
@@ -50,7 +50,11 @@ type gatewayDescribeView struct {
 func (gp *GatewaysPrinter) Print(resourceModel *resourcediscovery.ResourceModel) {
 	tw := tabwriter.NewWriter(gp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAME", "CLASS", "ADDRESSES", "PORTS", "PROGRAMMED", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	gatewayNodes := make([]*resourcediscovery.GatewayNode, 0, len(resourceModel.Gateways))
 	for _, gatewayNode := range resourceModel.Gateways {
@@ -98,7 +102,11 @@ func (gp *GatewaysPrinter) Print(resourceModel *resourcediscovery.ResourceModel)
 			programmedStatus,
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }

gwctl/pkg/printer/httproutes.go

@@ -27,10 +27,10 @@ import (
 	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/policymanager"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/resourcediscovery"
-	"sigs.k8s.io/yaml"
 
 	"k8s.io/apimachinery/pkg/util/duration"
 	"k8s.io/utils/clock"
+	"sigs.k8s.io/yaml"
 )
 
 type HTTPRoutesPrinter struct {
@@ -41,7 +41,11 @@ type HTTPRoutesPrinter struct {
 func (hp *HTTPRoutesPrinter) Print(resourceModel *resourcediscovery.ResourceModel) {
 	tw := tabwriter.NewWriter(hp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAMESPACE", "NAME", "HOSTNAMES", "PARENT REFS", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	httpRouteNodes := make([]*resourcediscovery.HTTPRouteNode, 0, len(resourceModel.HTTPRoutes))
 	for _, httpRouteNode := range resourceModel.HTTPRoutes {
@@ -80,7 +84,11 @@ func (hp *HTTPRoutesPrinter) Print(resourceModel *resourcediscovery.ResourceMode
 			parentRefsCount,
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }

gwctl/pkg/printer/namespace.go

@@ -26,10 +26,10 @@ import (
 
 	"k8s.io/apimachinery/pkg/util/duration"
 	"k8s.io/utils/clock"
+	"sigs.k8s.io/yaml"
 
 	"sigs.k8s.io/gateway-api/gwctl/pkg/policymanager"
 	"sigs.k8s.io/gateway-api/gwctl/pkg/resourcediscovery"
-	"sigs.k8s.io/yaml"
 )
 
 type NamespacesPrinter struct {
@@ -48,7 +48,11 @@ type namespaceDescribeView struct {
 func (nsp *NamespacesPrinter) Print(resourceModel *resourcediscovery.ResourceModel) {
 	tw := tabwriter.NewWriter(nsp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAME", "STATUS", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	namespaceNodes := make([]*resourcediscovery.NamespaceNode, 0, len(resourceModel.Namespaces))
 	for _, namespaceNode := range resourceModel.Namespaces {
@@ -66,7 +70,11 @@ func (nsp *NamespacesPrinter) Print(resourceModel *resourcediscovery.ResourceMod
 			string(namespaceNode.Namespace.Status.Phase),
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }

gwctl/pkg/printer/policies.go

@@ -25,12 +25,12 @@ import (
 	"text/tabwriter"
 
 	"sigs.k8s.io/gateway-api/gwctl/pkg/policymanager"
-	"sigs.k8s.io/yaml"
 
 	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/duration"
 	"k8s.io/utils/clock"
+	"sigs.k8s.io/yaml"
 )
 
 type PoliciesPrinter struct {
@@ -47,7 +47,11 @@ func (pp *PoliciesPrinter) PrintPoliciesGetView(policies []policymanager.Policy)
 
 	tw := tabwriter.NewWriter(pp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAME", "KIND", "TARGET NAME", "TARGET KIND", "POLICY TYPE", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	for _, policy := range policies {
 		policyType := "Direct"
@@ -67,7 +71,11 @@ func (pp *PoliciesPrinter) PrintPoliciesGetView(policies []policymanager.Policy)
 			policyType,
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }
@@ -81,7 +89,11 @@ func (pp *PoliciesPrinter) PrintPolicyCRDsGetView(policyCRDs []policymanager.Pol
 
 	tw := tabwriter.NewWriter(pp.Out, 0, 0, 2, ' ', 0)
 	row := []string{"NAME", "POLICY TYPE", "SCOPE", "AGE"}
-	tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+	if err != nil {
+		fmt.Fprint(os.Stderr, err)
+		os.Exit(1)
+	}
 
 	for _, policyCRD := range policyCRDs {
 		policyType := "Direct"
@@ -97,7 +109,11 @@ func (pp *PoliciesPrinter) PrintPolicyCRDsGetView(policyCRDs []policymanager.Pol
 			string(policyCRD.CRD().Spec.Scope),
 			age,
 		}
-		tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		_, err := tw.Write([]byte(strings.Join(row, "\t") + "\n"))
+		if err != nil {
+			fmt.Fprint(os.Stderr, err)
+			os.Exit(1)
+		}
 	}
 	tw.Flush()
 }