Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e jobs #105

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update e2e jobs #105

merged 1 commit into from
Nov 18, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 22, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2024
@aojea aojea mentioned this pull request Oct 22, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2024
@aojea aojea mentioned this pull request Oct 22, 2024
Closed
aojea
aojea commented Oct 23, 2024
View reviewed changes
.github/workflows/npa.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
aojea
aojea commented Oct 23, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
@aojea
Copy link
Contributor Author

aojea commented Oct 23, 2024

jobs are passing now, let me split the commit with the fix, so we can merge and revendor in kindnet, before we do a new kind release

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2024
@danwinship
Copy link

/lgtm
/hold
(I wasn't sure if your comment above meant to not merge this yet. Feel free to un-hold.)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@aojea
Copy link
Contributor Author

aojea commented Nov 18, 2024

/lgtm /hold (I wasn't sure if your comment above meant to not merge this yet. Feel free to un-hold.)

/hold cancel

now is good, @tssurya you should mimic this change to use the latest kind version and node image

Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit c6c60bb into kubernetes-sigs:main Nov 18, 2024
13 checks passed
@tssurya
Copy link

tssurya commented Nov 18, 2024

/lgtm /hold (I wasn't sure if your comment above meant to not merge this yet. Feel free to un-hold.)

/hold cancel

now is good, @tssurya you should mimic this change to use the latest kind version and node image

Thanks

ack on it, I will update my other PR in network-policy-api repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya left review comments

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aojea @k8s-ci-robot @danwinship @tssurya