-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm chart. #107
Add helm chart. #107
Conversation
awesome, do you mind add a sentence in kube-network-policies/README.md Line 7 in 4320aa9
|
- /bin/netpol | ||
- --hostname-override=$(MY_NODE_NAME) | ||
- --v=2 | ||
{{- if .Values.baselineAdminNetworkPolicy }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{- if .Values.baselineAdminNetworkPolicy }} | |
{{- if .Values.adminNetworkPolicy }} |
I learned this recently, so there is Admin Network Policy, that has two CRD adminNetworkPolicy and baseAdminNetworkPolicy , so, maybe better to name Values.adminNetworkPolicy
instead of Values.baselineAdminNetworkPolicy
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
JFYI, we specify both flags in install-anp. I could not come up with a generic parameter name that describes both AdminNetworkPolicy and BaselineAdminNetworkPolicy.
Renamed as suggested.
@mneverov naive question, the admin network policies require to install some CRDs, does helm practices recommend to embed those CRDs? kube-network-policies/.github/workflows/npa.yml Lines 110 to 111 in 4320aa9
|
For a user convenience CRDs are often embedded in the chart especially when they are defined in the same repo. CRDs can also be installed as a dependency, but in this case they should be also provided as a helm chart. I don't see helm charts for CRDs in network-policy-api, so users still need to install them manually. |
This is awesome, thank you very much /LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, mneverov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses #98
To test run
helm install kube-network-policies -n kube-system charts/kube-network-policies
.admin-network-policy
andbaseline-admin-network-policy
are enabled by default (values filebaselineAdminNetworkPolicy: true
).