Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ok-to-test label to approve GitHub workflow runs for new contributors #25210 #194

Open
MadhavJivrajani opened this issue Jun 14, 2024 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@MadhavJivrajani
Copy link
Contributor

Original Issue: kubernetes/test-infra#25210


What would you like to be added:
The ability for Prow to approve GitHub workflow runs after the ok-to-test label has been added to a PR via GitHub's API https://docs.github.com/en/rest/reference/actions#approve-a-workflow-run-for-a-fork-pull-request

Why is this needed:
New contributors are blocked from running GitHub workflows even after a maintainer adds the ok-to-test label to a PR and contributors shouldn't need to rely on GUI access to approve workflow runs knative/test-infra/issues/3057

@MadhavJivrajani
Copy link
Contributor Author

/sig contributor-experience

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
@tuminoid
Copy link
Contributor

/remove-lifecycle stale
This is still valid request. There is a workaround, but it would be nicer if it was an actual feature in Prow.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
@petr-muller petr-muller added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 20, 2024
@JesseStutler
Copy link

I'm from volcano community, we also wish to have this feature. Currently, the first PR from outside contributors must be approved by our owner and then trigger the github workflows, which contain some e2e testing. We wish that when there is /ok-to-test labeled, the workflows can be triggered, not keep waiting for the owner to approve.

@JesseStutler
Copy link

Hi, @tuminoid , how do you solve this problem? Are there any best practices so far? Thanks.

@tuminoid
Copy link
Contributor

Hi, @tuminoid , how do you solve this problem? Are there any best practices so far? Thanks.

We are using this: kubernetes/test-infra#25210 (comment) as there is no better alternative right now.

@JesseStutler
Copy link

OK, thanks, I think currently this action is enough to help our community, hope that prow will implement this feature one day. Seems that there are multiple communities hoping to combine prow and github workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

6 participants