-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ok-to-test
label to approve GitHub workflow runs for new contributors #25210
#194
Comments
/sig contributor-experience |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
I'm from volcano community, we also wish to have this feature. Currently, the first PR from outside contributors must be approved by our owner and then trigger the github workflows, which contain some e2e testing. We wish that when there is /ok-to-test labeled, the workflows can be triggered, not keep waiting for the owner to approve. |
Hi, @tuminoid , how do you solve this problem? Are there any best practices so far? Thanks. |
We are using this: kubernetes/test-infra#25210 (comment) as there is no better alternative right now. |
OK, thanks, I think currently this action is enough to help our community, hope that prow will implement this feature one day. Seems that there are multiple communities hoping to combine prow and github workflows. |
Original Issue: kubernetes/test-infra#25210
What would you like to be added:
The ability for Prow to approve GitHub workflow runs after the
ok-to-test
label has been added to a PR via GitHub's API https://docs.github.com/en/rest/reference/actions#approve-a-workflow-run-for-a-fork-pull-requestWhy is this needed:
New contributors are blocked from running GitHub workflows even after a maintainer adds the
ok-to-test
label to a PR and contributors shouldn't need to rely on GUI access to approve workflow runs knative/test-infra/issues/3057The text was updated successfully, but these errors were encountered: