-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add approve workflows action #3758
Conversation
Signed-off-by: jessestutler <[email protected]>
/assign @Monokaix |
Who has permission to add ok-to-test label? |
/ok-to-test |
@JesseStutler: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BackGround
When contributors from outside contribute their first PR to volcano repo, the repo admin has to click the
approve and run
button to run the CI, even the approvers don't have the permissions to run the CIs when they are not repo admin. And the volcano-bot cannot automatically run CIs, because the bot usesprow
as the testing framework. Currentlyprow
uses k8s' own testing framework, and its integration with github workflow is not so good. So, inspired by this issue: kubernetes-sigs/prow#194, and this config: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml, we can add a action, when there isok-to-test
label in this first PR(which is already reviewed by reviewers), this github workflow can be ran to call other workflows. Therefore, approvers can have the right to run CIs, not only the repo admin.Testing
Test-1
Add
ok-to-test
label,Approve Workflow
action can run:And other workflows can run subsequently:
Test-2
Tag other labels, other workflows can't run, and
Approve Workflows
action is skippedTest-3
PR to non
release-**
andmaster
branch,ok-to-test
label is useless, only PR torelease-**
andmaster
branch is useful.