Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates security section #1378

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Nov 17, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Updates security documentation.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2023
@nilekhc nilekhc requested review from tam7t and removed request for ritazh and aramase November 17, 2023 00:34
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2023
@nilekhc nilekhc requested review from ritazh, enj and aramase November 17, 2023 00:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (841fb0d) 55.00% compared to head (7b79a29) 55.00%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          22       22           
  Lines        2327     2327           
=======================================
  Hits         1280     1280           
  Misses        923      923           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nilekhc
Copy link
Contributor Author

nilekhc commented Nov 17, 2023

/test pull-secrets-store-csi-driver-e2e-windows

docs/book/src/concepts.md Outdated Show resolved Hide resolved
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@nilekhc
Copy link
Contributor Author

nilekhc commented Dec 5, 2023

/test pull-secrets-store-csi-driver-e2e-windows

3 similar comments
@nilekhc
Copy link
Contributor Author

nilekhc commented Dec 15, 2023

/test pull-secrets-store-csi-driver-e2e-windows

@nilekhc
Copy link
Contributor Author

nilekhc commented Jan 2, 2024

/test pull-secrets-store-csi-driver-e2e-windows

@nilekhc
Copy link
Contributor Author

nilekhc commented Jan 3, 2024

/test pull-secrets-store-csi-driver-e2e-windows

Signed-off-by: Nilekh Chaudhari <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 8, 2024

@nilekhc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-image-scan c219f51 link false /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 1bbc782 into kubernetes-sigs:main Jan 8, 2024
25 of 26 checks passed
@nilekhc nilekhc deleted the update-docs branch January 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants