Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use e2e-provider for manifest tests #1573

Merged
merged 1 commit into from
Jul 16, 2024
Merged

test: use e2e-provider for manifest tests #1573

merged 1 commit into from
Jul 16, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 16, 2024 •
edited
Loading

  • Use e2e-provider for manifest tests

This enables us to move to eks prow cluster without any dependencies on secrets used by the azure provider.

part of #1273

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot requested review from nilekhc and tam7t July 16, 2024 19:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
@aramase aramase mentioned this pull request Jul 16, 2024
Merged
@aramase
Copy link
Member Author

aramase commented Jul 16, 2024

/test pull-secrets-store-csi-driver-e2e-deploy-manifest-e2e-provider

@aramase aramase marked this pull request as ready for review July 16, 2024 21:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@aramase
Copy link
Member Author

aramase commented Jul 16, 2024

test passing: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_secrets-store-csi-driver/1573/pull-secrets-store-csi-driver-e2e-deploy-manifest-e2e-provider/1813320311353905152

@nilekhc
Copy link
Contributor

nilekhc commented Jul 16, 2024

test passing: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_secrets-store-csi-driver/1573/pull-secrets-store-csi-driver-e2e-deploy-manifest-e2e-provider/1813320311353905152

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 555135f into kubernetes-sigs:main Jul 16, 2024
26 checks passed
@aramase aramase deleted the aramase/t/yaml_test branch July 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilekhc nilekhc Awaiting requested review from nilekhc

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@nilekhc nilekhc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramase @k8s-ci-robot @nilekhc