Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update manifest and helm charts for v1.4.6 #1662

Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Oct 9, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

update manifest and helm charts for v1.4.6

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

/assign @aramase

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aramase October 9, 2024 18:50
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ritazh October 9, 2024 18:50
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 9, 2024
@nilekhc nilekhc force-pushed the nilekh/c/release-driver-v1.4.6 branch from 5159b4b to 5b93433 Compare October 9, 2024 18:52
@nilekhc
Copy link
Contributor Author

nilekhc commented Oct 9, 2024

/retitle release: update manifest and helm charts for v1.4.6

@k8s-ci-robot k8s-ci-robot changed the title Nilekh/c/release driver v1.4.6 release: update manifest and helm charts for v1.4.6 Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.69%. Comparing base (87f51ec) to head (22a4908).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
- Coverage   35.83%   35.69%   -0.14%     
==========================================
  Files          63       63              
  Lines        3759     3754       -5     
==========================================
- Hits         1347     1340       -7     
- Misses       2268     2270       +2     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nilekhc nilekhc force-pushed the nilekh/c/release-driver-v1.4.6 branch from 041f740 to 22a4908 Compare October 9, 2024 19:36
@nilekhc
Copy link
Contributor Author

nilekhc commented Oct 9, 2024

/retest

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
(for v1.4.6 tag to be cut)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@aramase
Copy link
Member

aramase commented Oct 9, 2024

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2024
@nilekhc nilekhc merged commit b76b155 into kubernetes-sigs:main Oct 9, 2024
28 checks passed
@nilekhc nilekhc deleted the nilekh/c/release-driver-v1.4.6 branch October 9, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants