test: add e2e test setup for GCP provider #1701

dargudear-google · 2024-12-05T13:04:07Z

What type of PR is this?

/kind failing-test

What this PR does / why we need it: Runs e2e test for driver with gcp provider

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1583

Special notes for your reviewer:
Earlier gcp tests were using hardcoded static secrets from google owned project. Now this PR uses secrets freshly created on boskos project.

TODOs:

squashed commits
includes documentation

k8s-ci-robot · 2024-12-05T13:04:17Z

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-12-05T13:44:59Z

@dargudear-google: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-secrets-store-csi-driver-e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

aramase · 2024-12-06T14:24:44Z

/ok-to-test

dargudear-google · 2024-12-06T14:46:41Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T14:59:17Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T15:03:55Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T15:18:34Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T15:28:11Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T16:05:34Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T16:41:01Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T17:02:30Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T17:15:57Z

test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T17:16:56Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-06T17:33:13Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-09T04:45:59Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-13T18:32:54Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2024-12-13T18:36:26Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-07T11:16:37Z

/test pull-secrets-store-csi-driver-e2e-gcp

k8s-ci-robot · 2025-01-07T15:49:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dargudear-google
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dargudear-google · 2025-01-08T04:48:50Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-08T14:56:42Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-08T15:51:05Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-09T02:37:51Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-09T02:50:51Z

/test pull-secrets-store-csi-driver-e2e-gcp

dargudear-google · 2025-01-09T08:20:12Z

/test pull-secrets-store-csi-driver-e2e-gcp

k8s-ci-robot · 2025-01-09T11:44:02Z

@dargudear-google: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-secrets-store-csi-driver-image-scan	`a7f7ec2`	link	false	`/test pull-secrets-store-csi-driver-image-scan`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dargudear-google · 2025-01-09T13:40:23Z

/test pull-secrets-store-csi-driver-e2e-gcp

aramase · 2025-01-09T16:15:08Z

/retitle test: add e2e test setup for GCP provider

aramase

Few minor nits!

aramase · 2025-01-09T16:17:54Z

test/bats/gcp.bats

+  echo -n "secret-b" | gcloud secrets versions add ${SECRET_ID} --data-file=-
+
+  # wait for secret rotation
+  sleep 120


How long does it take for rotation to take effect in secret manager? Could you add a comment here?

aramase · 2025-01-09T16:18:22Z

test/scripts/run-e2e-gcp.sh

@@ -0,0 +1,97 @@
+#!/usr/bin/env bash
+
+# Copyright 2024 The Kubernetes Authors.


Suggested change

# Copyright 2024 The Kubernetes Authors.

# Copyright 2025 The Kubernetes Authors.

aramase · 2025-01-09T17:54:08Z

test/scripts/run-e2e-gcp.sh

+main() {
+    echo "starting the secret store csi driver test for gcp provider"
+
+    #install boskosctl


Suggested change

#install boskosctl

# install boskosctl

aramase · 2025-01-09T17:54:53Z

test/scripts/run-e2e-gcp.sh

+    echo "testing boskosctl"
+    boskosctl --help
+
+    # Aquire a project from boskos pool, test will use secret created on this aquired project


Suggested change

# Aquire a project from boskos pool, test will use secret created on this aquired project

# Acquire a project from boskos pool, test will use secret created on this acquired project

aramase · 2025-01-09T17:56:09Z

test/scripts/run-e2e-gcp.sh

+        RESOURCE_NAME=$(echo "$BOSKOS_RESOURCE" | jq -r ".name")
+        export RESOURCE_NAME
+        GCP_PROJECT=$(echo "$BOSKOS_RESOURCE" | jq -r ".name")
+        export GCP_PROJECT


The RESOURCE_NAME and GCP_PROJECT are the same. Could we just use a single var instead or does this need to be 2 different ones for clarity?

aramase · 2025-01-09T17:57:53Z

test/scripts/run-e2e-gcp.sh

+    echo "Using project ${GCP_PROJECT}"
+    gcloud config set project "${GCP_PROJECT}"
+
+    # create a secret in the aquired project 


Suggested change

# create a secret in the aquired project

# create a secret in the acquired project

aramase · 2025-01-09T17:58:34Z

test/scripts/run-e2e-gcp.sh

+    --role=roles/secretmanager.secretAccessor \
+    --member=principalSet://iam.googleapis.com/projects/773781448124/locations/global/workloadIdentityPools/k8s-infra-prow-build.svc.id.goog/namespace/test-pods
+
+    # wait for permissions to propogate


Suggested change

# wait for permissions to propogate

# wait for permissions to propagate

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024

k8s-ci-robot requested review from aramase and nilekhc December 5, 2024 13:04

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024

dargudear-google force-pushed the provider-gcp-test branch from 9b14c0b to 942f7d0 Compare December 6, 2024 06:36

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2024

dargudear-google force-pushed the provider-gcp-test branch from 1478bfc to dc753fd Compare December 6, 2024 06:41

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2024

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2024

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2024

dargudear-google force-pushed the provider-gcp-test branch from 39d590f to 3145ff1 Compare December 14, 2024 17:46

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 20, 2024

dargudear-google force-pushed the provider-gcp-test branch 3 times, most recently from a9f26b6 to ff90da3 Compare January 9, 2025 05:39

dargudear-google changed the title ~~TEST: GCP e2e test~~ E2E test for GCP provider Jan 9, 2025

dargudear-google marked this pull request as ready for review January 9, 2025 07:36

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025

e2e test of gcp-provider.

42e7efe

dargudear-google force-pushed the provider-gcp-test branch from 84528da to 42e7efe Compare January 9, 2025 08:06

Add condition for release

a7f7ec2

k8s-ci-robot changed the title ~~E2E test for GCP provider~~ test: add e2e test setup for GCP provider Jan 9, 2025

aramase requested changes Jan 9, 2025

View reviewed changes

		@@ -0,0 +1,97 @@
		#!/usr/bin/env bash

		# Copyright 2024 The Kubernetes Authors.

	# Copyright 2024 The Kubernetes Authors.
	# Copyright 2025 The Kubernetes Authors.

	# Aquire a project from boskos pool, test will use secret created on this aquired project
	# Acquire a project from boskos pool, test will use secret created on this acquired project

	# create a secret in the aquired project
	# create a secret in the acquired project

	# wait for permissions to propogate
	# wait for permissions to propagate

test: add e2e test setup for GCP provider #1701

Are you sure you want to change the base?

test: add e2e test setup for GCP provider #1701

Conversation

dargudear-google commented Dec 5, 2024 • edited Loading

k8s-ci-robot commented Dec 5, 2024

k8s-ci-robot commented Dec 5, 2024

aramase commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 6, 2024

dargudear-google commented Dec 9, 2024

dargudear-google commented Dec 13, 2024

dargudear-google commented Dec 13, 2024

dargudear-google commented Jan 7, 2025

k8s-ci-robot commented Jan 7, 2025

dargudear-google commented Jan 8, 2025

dargudear-google commented Jan 8, 2025

dargudear-google commented Jan 8, 2025

dargudear-google commented Jan 9, 2025

dargudear-google commented Jan 9, 2025

dargudear-google commented Jan 9, 2025

k8s-ci-robot commented Jan 9, 2025 • edited Loading

dargudear-google commented Jan 9, 2025

aramase commented Jan 9, 2025

aramase left a comment

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

aramase Jan 9, 2025

Choose a reason for hiding this comment

dargudear-google commented Dec 5, 2024 •

edited

Loading

k8s-ci-robot commented Jan 9, 2025 •

edited

Loading