Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Etcd Spotlight #564

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add SIG Etcd Spotlight #564

wants to merge 11 commits into from

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Jan 17, 2025

Add SIG Etcd Spotlight interview.

Closes: #489

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2025
jberkus
jberkus suggested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues to fix before we can publish. Mainly, we're missing some charts.

content/en/blog/2025/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
@jberkus
Copy link
Contributor

jberkus commented Jan 25, 2025

Looks good now, ready to publish.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fsmunoz
Once this PR has been reviewed and has the lgtm label, please ask for approval from jberkus. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jan 31, 2025

Thanks @jberkus . I've updated the document with some final edits (almost everything around adding links), and I'm removing the WIP tag.

/retitle Add SIG Etcd Spotlight

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add SIG Etcd Spotlight Add SIG Etcd Spotlight Jan 31, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@fsmunoz fsmunoz mentioned this pull request Jan 31, 2025
Open
sftim
sftim reviewed Feb 1, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I recommend tweaking

content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Show resolved Hide resolved
content/en/blog/2025/sig-etcd-spotlight/sig-etcd-spotlight.md Outdated Show resolved Hide resolved
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Feb 6, 2025

Changed publication date and reflected all comments. I'm going to update the website PR as well.

@reylejano
Copy link
Member

This looks good
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkus jberkus jberkus requested changes

@sftim sftim sftim left review comments

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@jberkus jberkus

@reylejano reylejano

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a SIG Etcd spotlight article
5 participants
@fsmunoz @jberkus @k8s-ci-robot @reylejano @sftim