Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [email protected] group #6542

Merged
merged 2 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions groups/groups_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,13 @@ func TestGroupConventions(t *testing.T) {
for _, g := range cfg.Groups {
// groups are easier to reason about if email and name match
expectedEmailId := g.Name + "@kubernetes.io"
// sig-etcd keeps using [email protected], but the name "security"
// has already been used by "[email protected]", so we use
// the name "etcd-security". Refer to discussion in
// https://github.com/kubernetes/k8s.io/pull/6542.
if g.Name == "etcd-security" {
expectedEmailId = "[email protected]"
}
if g.EmailId != expectedEmailId {
t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId)
}
Expand Down
3 changes: 3 additions & 0 deletions groups/restrictions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ restrictions:
- "^[email protected]$"
- "^[email protected]$"
- "^[email protected]$"
- path: "sig-etcd/groups.yaml"
allowedGroups:
- "@etcd.io$"
- path: "sig-docs/groups.yaml"
allowedGroups:
- "^[email protected]$"
Expand Down
9 changes: 9 additions & 0 deletions groups/sig-etcd/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- sig-etcd-leads
reviewers:
- sig-etcd-leads

labels:
- sig/etcd
15 changes: 15 additions & 0 deletions groups/sig-etcd/groups.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
groups:
- email-id: [email protected]
name: etcd-security
ahrtr marked this conversation as resolved.
Show resolved Hide resolved
description: |-
Private list for non-public (internal) triage of etcd security vulnerabilities
reported by any etcd contributors or users.
settings:
WhoCanPostMessage: "ANYONE_CAN_POST"
ReconcileMembers: "true"
owners:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]