Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goreleaser actions #3297

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add goreleaser actions #3297

merged 1 commit into from
Oct 5, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a GitHub action to release the release-notes tool as well as krel via goreleaser.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2023
@saschagrunert saschagrunert changed the title Add goreleaser actions WIP: Add goreleaser actions Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2023
@saschagrunert saschagrunert force-pushed the goreleaser branch 2 times, most recently from e045d41 to 5858c80 Compare October 2, 2023 09:46
@saschagrunert saschagrunert changed the title WIP: Add goreleaser actions Add goreleaser actions Oct 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023
@saschagrunert
Copy link
Member Author

PTAL @kubernetes/release-engineering

@xmudrii
Copy link
Member

xmudrii commented Oct 2, 2023

@saschagrunert There's a (strong) preference from SIG Testing and GitHub Admins to use Prow as much as possible. Why do we use GH Actions here instead of using Prow? We could more-or-less easily do everything in Prow.

@saschagrunert
Copy link
Member Author

saschagrunert commented Oct 2, 2023 •
edited
Loading

@saschagrunert There's a (strong) preference from SIG Testing and GitHub Admins to use Prow as much as possible. Why do we use GH Actions here instead of using Prow? We could more-or-less easily do everything in Prow.

We already use goreleaser, for example in zeitgeist: https://github.com/kubernetes-sigs/zeitgeist/blob/master/.goreleaser.yml

cpanato
cpanato requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that

just a few comments

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
@cpanato
Copy link
Member

cpanato commented Oct 2, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2023
@saschagrunert
Add goreleaser actions
96544ed 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@cpanato addressed everything. PTAL again.

This was referenced Oct 4, 2023
Merged
Merged
cpanato
cpanato approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

lets run a release to try this out!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

@cpanato can we lift the hold?

@cpanato
Copy link
Member

cpanato commented Oct 5, 2023

/unhold

sorry did not notice that :/

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6d0cb46 into kubernetes:master Oct 5, 2023
5 checks passed
@saschagrunert saschagrunert deleted the goreleaser branch October 5, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @xmudrii @cpanato @k8s-ci-robot