-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt krel/ff to run with other repositories that are not only k/k #3445
Conversation
Signed-off-by: cpanato <[email protected]>
/hold |
@@ -188,7 +188,6 @@ func GetK8sRef() string { | |||
// GetK8sRef() point to their default values. | |||
func IsDefaultK8sUpstream() bool { | |||
return GetK8sOrg() == DefaultK8sOrg && | |||
GetK8sRepo() == DefaultK8sRepo && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm wondering why we modify this 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this funcition is used in the FF and now we will need expand to other repo and not only for k/k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! /unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
/assign @saschagrunert @puerco @xmudrii
cc @kubernetes/release-engineering @katcosgrove
Which issue(s) this PR fixes:
Fixes #3380
Special notes for your reviewer:
Does this PR introduce a user-facing change?