-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change repo-path default for release-note generate cmd #3458
change repo-path default for release-note generate cmd #3458
Conversation
Welcome @DannyBrito! |
Hi @DannyBrito. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
d642cbd
to
7d433dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution and bearing with us, @DannyBrito!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DannyBrito, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR changes repo-path value from release-note generate command when omitted to use
temp/<gh-org>-<gh-repo>
to prevent issue of trying to clone/update incorrect repo in existingpath
.cc: @jeremyrickard
Which issue(s) this PR fixes:
Fixes #3444
Special notes for your reviewer:
Does this PR introduce a user-facing change?