Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: add markdown lint presubmit job #34369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

etcd: add markdown lint presubmit job #34369

wants to merge 1 commit into from

Conversation

joshjms
Copy link

@joshjms joshjms commented Feb 19, 2025 •
edited
Loading

Prow job for markdown linting.

For etcd-io/etcd#18059

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 19, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: joshjms / name: Joshua James (17a8cd0)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshjms
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @joshjms!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joshjms. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshjms joshjms force-pushed the pull-etcd-markdown-lint branch from 660a054 to 7bd6ef8 Compare February 19, 2025 18:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 19, 2025
@joshjms joshjms force-pushed the pull-etcd-markdown-lint branch from 7bd6ef8 to 0264f95 Compare February 19, 2025 18:32
ivanvc
ivanvc reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request, @joshjms. I left some comments/suggestions.

Could you also please set the job as optional meanwhile?

I think your branch may also need a rebase with master.

Thanks again ✌️

config/jobs/etcd/etcd-presubmits.yaml Outdated
run_if_changed: '.*\.md$'
branches:
- main
- release-3.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop release-3.6 initially, as I'm not sure we'll backport this to v3.6.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config/jobs/etcd/etcd-presubmits.yaml Outdated
testgrid-tab-name: pull-etcd-markdown-lint
spec:
containers:
- image: us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e:v20250205-f1f3519e6b-master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must use public.ecr.aws/docker/library/node:20 (or 22, the current LTS). The kubekins-e2e image doesn't have NodeJS installed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I used the kubekins-e2e image and installed nodejs and npm in the scripts. Will change accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config/jobs/etcd/etcd-presubmits.yaml Outdated
memory: "4Gi"
limits:
cpu: "2"
memory: "4Gi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you add a linebreak at the end of the last line? Thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@joshjms joshjms force-pushed the pull-etcd-markdown-lint branch from 0264f95 to 2a27a0c Compare February 26, 2025 02:09
@joshjms
etcd: add markdown lint presubmit job
17a8cd0 
Signed-off-by: joshjms <[email protected]>

etcd: changed image

etcd: add line break
@joshjms joshjms force-pushed the pull-etcd-markdown-lint branch from 2a27a0c to 17a8cd0 Compare February 26, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc left review comments

@jmhbnz jmhbnz Awaiting requested review from jmhbnz

@serathius serathius Awaiting requested review from serathius

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshjms @k8s-ci-robot @ivanvc