Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR job to verify winsylink removal with azuredisk csi driver in a K8s cluster #34388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marosset
Copy link
Contributor

Adds a PR job to build a windows cluster with run-capz-e2e.sh and then run the azuredisk-csi-driver e2e test

This targets a fork for run-capz-e2e.sh with marosset/windows-testing@f5bbb63 so we can run the azuredisk-csi-driver e2e tests instead of k/k e2e tests like the script normally runs.

I will merge the changes into k-sigs/windows-testing after we do some additional validation

/sig windows
/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

@marosset: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig 0cde9b8 link true /test pull-test-infra-prow-checkconfig
pull-test-infra-unit-test 0cde9b8 link true /test pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking 0cde9b8 link false /test pull-test-infra-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsturtevant
Copy link
Contributor

/hold

I think these jobs would cover this requirement

pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-capz-azure-file-windows
pull-kubernetes-e2e-capz-azure-disk
pull-kubernetes-e2e-capz-azure-disk-windows

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants