Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to stdlib slices breaks golang 1.18-1.20 compatibility #316

Closed
gibizer opened this issue Aug 27, 2024 · 0 comments · Fixed by #317
Closed

Switching to stdlib slices breaks golang 1.18-1.20 compatibility #316

gibizer opened this issue Aug 27, 2024 · 0 comments · Fixed by #317

Comments

@gibizer
Copy link
Contributor

gibizer commented Aug 27, 2024

What happened:
Bumping to the latest version including 4965b0f in a project using golang 1.20 (e.g.openstack-k8s-operators/nova-operator#847) breaks as slices is only added to sdlib in golang 1.21. The commit 4965b0f did not changed the go.mod file to indicate that this repo now only support 1.21 either.

What you expected to happen:

I expect that such change only happens after #308 has been landed.

How to reproduce it:

bump to version 4965b0f or newer in an env using golang < 1.21

gibizer added a commit to gibizer/utils that referenced this issue Aug 27, 2024
This reverts commit 4965b0f as it
incorrectly started using stdlib slices without declaring that this repo
is now only compatible with golang >=1.21.

Closes: kubernetes#316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant