Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Deprecate strings/slices functions covered by stdlib slices" #317

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Revert "Deprecate strings/slices functions covered by stdlib slices" #317

merged 1 commit into from
Sep 2, 2024

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Aug 27, 2024

This reverts commit 4965b0f as it
incorrectly started using stdlib slices without declaring that this repo
is now only compatible with golang >=1.21.

Closes: #316

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 27, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 27, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gibizer / name: Balazs Gibizer (8866f61)

@k8s-ci-robot k8s-ci-robot requested review from dims and lavalamp August 27, 2024 08:13
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @gibizer!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2024
@gibizer
Revert "Deprecate strings/slices functions covered by stdlib slices"
8866f61 
This reverts commit 4965b0f as it
incorrectly started using stdlib slices without declaring that this repo
is now only compatible with golang >=1.21.
@gibizer gibizer force-pushed the revert-stdlib-slices branch from b9864d0 to 8866f61 Compare August 27, 2024 08:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 27, 2024
@gibizer
Copy link
Contributor Author

gibizer commented Aug 27, 2024

/easycla

1 similar comment
@gibizer
Copy link
Contributor Author

gibizer commented Aug 29, 2024

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 29, 2024
@gibizer
Copy link
Contributor Author

gibizer commented Sep 2, 2024

@thockin could you check this please? (Sorry for pinging directly but you were the approver of the commit I propose to revert here)

@gibizer gibizer mentioned this pull request Sep 2, 2024
Merged
1 task
gibizer added a commit to gibizer/renovate-config that referenced this pull request Sep 2, 2024
@gibizer
[renovate]Do not follow k8s.io/utils
c2ca89d 
This module has no semantic version tags and following pseudoversions
are expensive and sometimes[1] dangerous. So this commit disables
the automatic update of this module and instead we rely on bumping this
when other k8s.io modules transitively require them.

[1]kubernetes/utils#317
@gibizer gibizer mentioned this pull request Sep 2, 2024
Merged
@thockin
Copy link
Member

thockin commented Sep 2, 2024

Oof. OK. We could add those "deprecated" comments sooner and change the impl later.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 702e33f into kubernetes:master Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switching to stdlib slices breaks golang 1.18-1.20 compatibility
3 participants
@gibizer @k8s-ci-robot @thockin