-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix busybox nslookup
example
#13071
Fix busybox nslookup
example
#13071
Conversation
* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28 * remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit ec355bb https://deploy-preview-13071--kubernetes-io-master-staging.netlify.com |
Hi, @voelzmo thanks for the PR. Before we can take a look, can you please sign the CLA?
|
Hey @cody-clark, thanks for the response. I'm trying to get under the umbrella of our corporate CLA, this might take a few days. Thanks! |
Woha, this was faster than I expected: I should be covered under the corporate CLA now. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cody-clark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28 * remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
/bin/sh
from the command to be executed on busybox, this leads to/bin/sh: can't open 'nslookup': No such file or directory