Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busybox nslookup example #13071

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented Mar 11, 2019

* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28
* remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ec355bb

https://deploy-preview-13071--kubernetes-io-master-staging.netlify.com

@cody-clark
Copy link
Contributor

Hi, @voelzmo thanks for the PR. Before we can take a look, can you please sign the CLA?

Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

@voelzmo
Copy link
Contributor Author

voelzmo commented Mar 12, 2019

Hey @cody-clark, thanks for the response. I'm trying to get under the umbrella of our corporate CLA, this might take a few days.

Thanks!

@voelzmo
Copy link
Contributor Author

voelzmo commented Mar 12, 2019

Woha, this was faster than I expected: I should be covered under the corporate CLA now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2019
@DanyC97
Copy link
Contributor

DanyC97 commented Mar 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit a3d246f into kubernetes:master Mar 12, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28
* remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants