-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LimitRange Documentation. #48766
base: main
Are you sure you want to change the base?
Conversation
T-Lakshmi
commented
Nov 19, 2024
- Improved overall LimitRange Documentation by fixing format and indentation.
- Closes: Improvement for k8s.io/docs/concepts/policy/limit-range/ #46899
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig node |
- First, the LimitRange admission controller applies default request and limit values for all Pods (and their containers) that do not set compute resource requirements. | ||
- Second, the LimitRange tracks usage to ensure it does not exceed resource minimum, maximum and ratio defined in any LimitRange present in the namespace. | ||
- If you attempt to create or update an object (Pod or PersistentVolumeClaim) that violates a LimitRange constraint, | ||
your request to the API server will fail with an HTTP status code `403 Forbidden` and a message explaining the constraint that has been violated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd do this:
- First, the LimitRange admission controller applies default request and limit values for all Pods (and their containers) that do not set compute resource requirements. | |
- Second, the LimitRange tracks usage to ensure it does not exceed resource minimum, maximum and ratio defined in any LimitRange present in the namespace. | |
- If you attempt to create or update an object (Pod or PersistentVolumeClaim) that violates a LimitRange constraint, | |
your request to the API server will fail with an HTTP status code `403 Forbidden` and a message explaining the constraint that has been violated. | |
- First, the LimitRange admission controller applies default request and limit values | |
for all Pods (and their containers) that do not set compute resource requirements. | |
- Second, the LimitRange tracks usage to ensure it does not exceed resource minimum, | |
maximum and ratio defined in any LimitRange present in the namespace. | |
- If you attempt to create or update an object (Pod or PersistentVolumeClaim) that | |
violates a LimitRange constraint, your request to the API server will fail with | |
an HTTP status code `403 Forbidden` and a message explaining the constraint that | |
has been violated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tengqm,
Thanks for the sharing your opinion. I updated the same.
PTAL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed to see the revision in your new commit.
The point is that we encourage indenting all lines under a bulletin (not just the first
line), so that the whole list is more readable in Markdown source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood! let me update it.