Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PV Storage Task #49130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve PV Storage Task #49130

wants to merge 1 commit into from
+195 −14

Conversation

network-charles
Copy link
Contributor

Description

This PR improves the explanation of this section titled "Mounting the same persistentVolume in two places" in the Configure a Pod to Use a PersistentVolume for Storage page.

  1. I used the existing PV and PVC in this example.
  2. I created a new nginx.conf file to show the file referenced in the pods manifest.
  3. I explained why a subPath is used.

Issue

Closes: #43293 and #49119

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f31a752
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6783b56a6fcf0300087506f7
😎 Deploy Preview https://deploy-preview-49130--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Dec 17, 2024

Also relevant to #45873

sftim
sftim reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK; one nit

content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@network-charles network-charles force-pushed the network-charles-patch-2 branch from 35aa383 to a2770cd Compare January 12, 2025 05:00
colossus06
colossus06 reviewed Jan 12, 2025
View reviewed changes
Copy link
Contributor

@colossus06 colossus06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md Show resolved Hide resolved
@network-charles @colossus06
improve pv storage task
f31a752 
Co-authored-by: Tim Bannister <[email protected]>

Co-authored-by: Gulcan Topcu <[email protected]>
@network-charles network-charles force-pushed the network-charles-patch-2 branch from a2770cd to f31a752 Compare January 12, 2025 12:28
@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

Slight link to #49420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colossus06 colossus06 colossus06 left review comments

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/tasks/configure-pod-container/configure-persistent-volume-storage/
4 participants
@network-charles @sftim @k8s-ci-robot @colossus06