Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: graduate WaitForAllControlPlaneComponents to Beta #49666

Merged
merged 1 commit into from
Feb 7, 2025
Merged

kubeadm: graduate WaitForAllControlPlaneComponents to Beta #49666

merged 1 commit into from
Feb 7, 2025

Conversation

neolit123
Copy link
Member

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e74b41a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67a4cc052e4e5500086a8441

@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/cc @HirazawaUi
ptal for lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 6, 2025
@neolit123
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2025
@neolit123 neolit123 mentioned this pull request Feb 6, 2025
Open
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e74b41a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67a4cc05cdc27b0008efd200
😎 Deploy Preview https://deploy-preview-49666--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HirazawaUi
HirazawaUi reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@HirazawaUi HirazawaUi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4ebc6b9b78c7c34d4ede1679ed403d7744d8480

@neolit123
Copy link
Member Author

/assign @katcosgrove

sftim
sftim reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 464cc34 into kubernetes:dev-1.33 Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@HirazawaUi HirazawaUi HirazawaUi left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@katcosgrove katcosgrove

@HirazawaUi HirazawaUi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neolit123 @k8s-ci-robot @sftim @HirazawaUi @katcosgrove