-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused RestClient param #10
Merged
xcoulon
merged 5 commits into
kubesaw:master
from
xcoulon:drop_commandcontext_newrestclient
Mar 21, 2024
Merged
remove unused RestClient param #10
xcoulon
merged 5 commits into
kubesaw:master
from
xcoulon:drop_commandcontext_newrestclient
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
requested review from
MatousJobanek,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak,
mfrancisc and
drpaneas
as code owners
March 19, 2024 09:30
not used anymore Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
drop_commandcontext_newrestclient
branch
from
March 19, 2024 09:49
03bba43
to
1e745c3
Compare
MatousJobanek
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks for removing it
fix for the failed test: #18 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 65.33% 65.30% -0.04%
==========================================
Files 38 38
Lines 1979 1977 -2
==========================================
- Hits 1293 1291 -2
Misses 528 528
Partials 158 158
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not used anymore
Signed-off-by: Xavier Coulon [email protected]