Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused RestClient param #10

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Mar 19, 2024

not used anymore

Signed-off-by: Xavier Coulon [email protected]

not used anymore

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the drop_commandcontext_newrestclient branch from 03bba43 to 1e745c3 Compare March 19, 2024 09:49
@xcoulon xcoulon requested review from metlos and fbm3307 as code owners March 21, 2024 08:08
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks for removing it

@MatousJobanek
Copy link
Contributor

fix for the failed test: #18

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #10 (6abd25e) into master (722904c) will decrease coverage by 0.04%.
The diff coverage is 31.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   65.33%   65.30%   -0.04%     
==========================================
  Files          38       38              
  Lines        1979     1977       -2     
==========================================
- Hits         1293     1291       -2     
  Misses        528      528              
  Partials      158      158              
Files Coverage Δ
pkg/context/clusterconfig_command_context.go 75.00% <100.00%> (-1.93%) ⬇️
pkg/context/command_context.go 100.00% <100.00%> (ø)
pkg/cmd/add_space_users.go 76.92% <0.00%> (ø)
pkg/cmd/adm/register_member.go 51.16% <0.00%> (ø)
pkg/cmd/adm/restart.go 59.34% <0.00%> (ø)
pkg/cmd/adm/unregister_member.go 51.42% <0.00%> (ø)
pkg/cmd/approve.go 72.09% <0.00%> (ø)
pkg/cmd/ban.go 71.83% <0.00%> (ø)
pkg/cmd/create_social_event.go 85.33% <0.00%> (ø)
pkg/cmd/deactivate.go 68.18% <0.00%> (ø)
... and 7 more

@xcoulon xcoulon merged commit 0f1c2f5 into kubesaw:master Mar 21, 2024
6 of 7 checks passed
@xcoulon xcoulon deleted the drop_commandcontext_newrestclient branch March 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants