fix 2.0: use default transport to mock http requests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak,
mfrancisc,
drpaneas,
metlos and
fbm3307
as code owners
xcoulon
reviewed
Mar 22, 2024
pkg/client/client.go
Outdated
| }) | ||
| } | ||
|
|
||
| func NewClientWitTransport(token, apiEndpoint string, transport http.RoundTripper) (runtimeclient.Client, error) { |
There was a problem hiding this comment.
Suggested change
| func NewClientWitTransport(token, apiEndpoint string, transport http.RoundTripper) (runtimeclient.Client, error) { | |
| func NewClientWithTransport(token, apiEndpoint string, transport http.RoundTripper) (runtimeclient.Client, error) { |
There was a problem hiding this comment.
Friday's morning a2a3c2f
There was a problem hiding this comment.
And thanks for the catch ;-)
There was a problem hiding this comment.
can you please click on approve now? or is there anything still missing?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 65.28% 65.45% +0.17%
==========================================
Files 38 38
Lines 1976 1986 +10
==========================================
+ Hits 1290 1300 +10
Misses 528 528
Partials 158 158
|
xcoulon
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gock relies on the default transport that mocks