Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move generating commands under 'ksctl generate' sub-command #29

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Apr 3, 2024

  • create ksctl generate sub-command
  • move & rename ksctl adm generate-cli-configs into ksctl generate cli-configs
  • move & rename ksctl adm setup into ksctl generate admin-manifests
  • move other related adm/setup_*.go files to the folder generate/ and drop the setup_ prefix

KUBESAW-54

Copy link
Contributor

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a simple suggestion for the Generate cmd short/long explanations.

pkg/cmd/generate/generate.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #29 (9c4c924) into master (f971092) will decrease coverage by 0.24%.
The diff coverage is 5.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   65.27%   65.04%   -0.24%     
==========================================
  Files          40       41       +1     
  Lines        2042     2051       +9     
==========================================
+ Hits         1333     1334       +1     
- Misses        551      559       +8     
  Partials      158      158              
Files Coverage Δ
pkg/cmd/adm/adm.go 0.00% <ø> (ø)
pkg/cmd/generate/cluster.go 82.60% <ø> (ø)
pkg/cmd/generate/permissions.go 79.84% <ø> (ø)
pkg/cmd/generate/roles_manager.go 76.92% <ø> (ø)
pkg/cmd/generate/util.go 75.83% <ø> (ø)
pkg/cmd/root.go 88.23% <100.00%> (+0.35%) ⬆️
pkg/cmd/generate/cli_configs.go 73.61% <0.00%> (ø)
pkg/cmd/generate/admin-manifests.go 37.73% <0.00%> (ø)
pkg/cmd/generate/generate.go 0.00% <0.00%> (ø)

@MatousJobanek MatousJobanek merged commit b786246 into kubesaw:master Apr 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants