Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail if the provided user name is not k8s compliant #94

Merged

Conversation

MatousJobanek
Copy link
Contributor

we should fail if the provided name of the user is not compliant with k8s names and label values.

@xcoulon
Copy link
Contributor

xcoulon commented Dec 17, 2024

we should fail if the provided name of the user is not compliant with k8s names and label values.

it's much simpler and much better than sanitizing the username, indeed!

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this check 🙏

I have few minor questions/clarifications.

pkg/cmd/generate/cluster.go Show resolved Hide resolved
pkg/cmd/generate/cluster_test.go Show resolved Hide resolved
pkg/cmd/generate/cluster_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Thanks for answering my questions 🙏

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

pkg/cmd/generate/cluster_test.go Show resolved Hide resolved
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, i liked this approach

@MatousJobanek MatousJobanek merged commit bd8b116 into kubesaw:master Dec 19, 2024
7 checks passed
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (4f14714) to head (2513f76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   67.78%   68.02%   +0.23%     
==========================================
  Files          44       44              
  Lines        3216     3240      +24     
==========================================
+ Hits         2180     2204      +24     
  Misses        841      841              
  Partials      195      195              
Files with missing lines Coverage Δ
pkg/cmd/generate/cluster.go 85.71% <100.00%> (+8.79%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants