SUB-2768 - finish adding delete / review paths

[YiscahLevySilas1]

PR Type:

Enhancement

---

PR Description:

This PR introduces the addition of review and delete paths to various rules. These paths provide additional information for the alert system, allowing for more precise and actionable alerts. The changes are applied to a wide range of rule files, enhancing the overall functionality and reliability of the system.

---

PR Main Files Walkthrough:

files:

rules/rule-list-all-cluster-admins/raw.rego: Added delete paths to the alert system for cluster admins.
rules/resources-cpu-limit-and-request/raw.rego: Added review paths to the alert system for CPU limit and request.
rules/rule-can-delete-k8s-events/raw.rego: Added delete paths to the alert system for deleting Kubernetes events.
rules/rule-secrets-in-env-var/raw.rego: Added delete paths to the alert system for secrets in environment variables.
rules/rule-excessive-delete-rights/raw.rego: Added delete paths to the alert system for excessive delete rights.
rules/resources-memory-limit-and-request/raw.rego: Added review paths to the alert system for memory limit and request.
rules/set-seccomp-profile-RuntimeDefault/raw.rego: Added review paths to the alert system for setting seccomp profile to RuntimeDefault.
rules/host-network-access/raw.rego: Added delete paths to the alert system for host network access.
rules/set-procmount-default/raw.rego: Added review paths to the alert system for setting procmount to default.
rules/sudo-in-container-entrypoint/raw.rego: Added review paths to the alert system for sudo in container entrypoint.

---

User Description:

Overview

[codiumai-pr-agent-free]

PR Analysis

• 🎯 Main theme: Enhancing alert system by adding review and delete paths
• 📝 PR summary: This PR introduces the addition of review and delete paths to various rules in the alert system. These paths provide additional information for the alert system, allowing for more precise and actionable alerts. The changes are applied to a wide range of rule files, enhancing the overall functionality and reliability of the system.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 4, due to the large number of files changed and the complexity of the changes.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and the changes are consistent across multiple files. However, it would be beneficial to add tests to ensure the new paths are working as expected.

• 🤖 Code feedback:

  • relevant file: rules/rule-list-all-cluster-admins/raw.rego
    suggestion: Ensure that the added delete paths are correctly implemented and are providing the expected functionality. [important]
    relevant line: "deletePaths": [path],

  • relevant file: rules/resources-cpu-limit-and-request/raw.rego
    suggestion: Review the added review paths and make sure they are correctly implemented and are providing the expected functionality. [important]
    relevant line: "reviewPaths": [failed_paths],

  • relevant file: rules/rule-can-delete-k8s-events/raw.rego
    suggestion: Ensure that the added delete paths are correctly implemented and are providing the expected functionality. [important]
    relevant line: "deletePaths": [path],

  • relevant file: rules/rule-secrets-in-env-var/raw.rego
    suggestion: Review the added delete paths and make sure they are correctly implemented and are providing the expected functionality. [important]
    relevant line: "deletePaths": [path],

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[yuleib]

@YiscahLevySilas1 Do we have any system tests that needs to be fixed before merging those changes ?
is something going to be breaked due to that ?

[github-actions]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success