chore(release): 2.4.5 #4216
Merged
chore(release): 2.4.5 #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojack
requested review from
devcatalin,
topliceanurazvan and
olensmar
as code owners
|
@monojack could we check if there are any major electron/electron-builder upgrades available? |
Electron has 2 major increments. I took a quick look at the documented breaking changes and tried a search through the source code - looks like we're not using any of the changed/deprecated/removed symbols, though building for mac fails with some deprecation errors and missing properties
|
|
thanks @monojack - perhaps there is a 27.X upgrade that we should use for security fixes that won't break our build? |
|
Was just checking 27.x and 28.x, they both work. Which one would you like?? |
|
then I'd go for 28 - thanks! |
prevents issues related to empty spaces, line breaks, existing quotes etc.
monojack
force-pushed
the
release/v2.4.5
branch
from
c59d47b to
f1b4a40
Compare
monojack
force-pushed
the
release/v2.4.5
branch
from
f1b4a40 to
8baff8e
Compare
monojack
force-pushed
the
release/v2.4.5
branch
from
8baff8e to
9981be1
Compare
monojack
force-pushed
the
release/v2.4.5
branch
from
9981be1 to
6293976
Compare
olensmar
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
How to test it
Screenshots
Checklist