Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug of too many spaces in an array #2251

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix the bug of too many spaces in an array #2251

merged 1 commit into from
Oct 30, 2023

Conversation

wenchajun
Copy link
Member

fix #2241

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2023
@wenchajun
Copy link
Member Author

/cc @benjaminhuo @wanjunlei @pixiake

@pixiake
Copy link
Collaborator

pixiake commented Oct 30, 2023

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, wanjunlei, wenchajun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pixiake
Copy link
Collaborator

pixiake commented Oct 30, 2023

/lgtm

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d3f9157cdc9b86f15145e4cb971912d405811412

@ks-ci-bot ks-ci-bot merged commit f341ef6 into kubesphere:master Oct 30, 2023
2 checks passed
@benjaminhuo
Copy link
Member

Need to pick to kse-3.x?

@wenchajun
Copy link
Member Author

Need to pick to kse-3.x?

yes, I wil do it soon

@redscholar
Copy link
Collaborator

/cherry-pick release-3.4

@ks-ci-bot ks-ci-bot mentioned this pull request Oct 30, 2023
Merged
@ks-ci-bot
Copy link
Collaborator

@littleBlackHouse: new pull request created: #2253

In response to this:

/cherry-pick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanjunlei wanjunlei wanjunlei approved these changes

@benjaminhuo benjaminhuo Awaiting requested review from benjaminhuo

@pixiake pixiake Awaiting requested review from pixiake

Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s 1.26.7 / ks-installer v3.4.0 opensearch install error
6 participants
@wenchajun @pixiake @ks-ci-bot @benjaminhuo @redscholar @wanjunlei