wip

kubev2v · Dec 13, 2024 · cee5f94 · cee5f94
1 parent 55a4229
commit cee5f94
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 15 deletions.
diff --git a/packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdownItems.tsx b/packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdownItems.tsx
@@ -1,10 +1,12 @@
 import React from 'react';
-import { DropdownItemLink } from 'src/components/actions/DropdownItemLink';
+import { isPlanEditable } from 'src/modules/Plans/utils';
+import { PlanVMsEditModal } from 'src/modules/Plans/views/details/tabs/VirtualMachines/modals';
+import { useGetDeleteAndEditAccessReview } from 'src/modules/Providers/hooks';
 import { useModal } from 'src/modules/Providers/modals';
-import { getResourceUrl } from 'src/modules/Providers/utils/helpers';
 import { useForkliftTranslation } from 'src/utils/i18n';
 
-import { PlanModel, PlanModelRef } from '@kubev2v/types';
+import { PlanModel /*PlanModelRef*/ } from '@kubev2v/types';
+import { useActiveNamespace } from '@openshift-console/dynamic-plugin-sdk';
 import { DropdownItem } from '@patternfly/react-core/deprecated';
 
 import {
@@ -26,21 +28,21 @@ import {
 export const PlanActionsDropdownItems = ({ data }: PlanActionsDropdownItemsProps) => {
   const { t } = useForkliftTranslation();
   const { showModal } = useModal();
+  const [activeNamespace] = useActiveNamespace();
+  const permissions = useGetDeleteAndEditAccessReview({
+    model: PlanModel,
+    namespace: activeNamespace,
+  });
 
   const { obj: plan } = data;
 
-  const planURL = getResourceUrl({
-    reference: PlanModelRef,
-    name: plan?.metadata?.name,
-    namespace: plan?.metadata?.namespace,
-  });
-
   const phase = getPlanPhase(data);
 
   const canStart = canPlanStart(plan);
   const canReStart = canPlanReStart(plan);
   const isWarmAndExecuting = plan?.spec?.warm && isPlanExecuting(plan);
   const isArchived = isPlanArchived(plan);
+  const canEditPlan = permissions.canPatch && isPlanEditable(plan);
 
   const buttonStartLabel = canReStart ? t('Restart migration') : t('Start migration');
 
@@ -67,9 +69,13 @@ export const PlanActionsDropdownItems = ({ data }: PlanActionsDropdownItemsProps
   };
 
   return [
-    <DropdownItemLink key="EditPlan" href={planURL}>
+    <DropdownItem
+      key="EditPlan"
+      onClick={() => showModal(<PlanVMsEditModal plan={plan} editAction="PLAN" />)}
+      isDisabled={!canEditPlan}
+    >
       {t('Edit Plan')}
-    </DropdownItemLink>,
+    </DropdownItem>,
 
     <DropdownItem key="start" isDisabled={!canStart} onClick={onClickPlanStart}>
       {buttonStartLabel}
@@ -111,4 +117,4 @@ export const PlanActionsDropdownItems = ({ data }: PlanActionsDropdownItemsProps
 
 interface PlanActionsDropdownItemsProps {
   data: PlanData;
-}
+}
diff --git a/...e-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/modals/PlanVMsEditModal.tsx b/...e-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/modals/PlanVMsEditModal.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 import { PlanEditAction } from 'src/modules/Plans/utils/types/PlanEditAction';
-import { PlanEditPage } from 'src/modules/Plans/views/create/PlanEditPage';
+import { PlanEditPage } from 'src/modules/Plans/views/edit/PlanEditPage';
 import { useModal } from 'src/modules/Providers/modals';
 import { useInventoryVms } from 'src/modules/Providers/views';
 import { useForkliftTranslation } from 'src/utils/i18n';

diff --git a/...ift-console-plugin/src/modules/Providers/views/migrate/ProvidersUpdateVmMigrationPage.tsx b/...ift-console-plugin/src/modules/Providers/views/migrate/ProvidersUpdateVmMigrationPage.tsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import { PlanEditAction } from 'src/modules/Plans/utils/types/PlanEditAction';
 import { PlanMappingsSectionState } from 'src/modules/Plans/views/details/tabs/Mappings/PlanMappingsSection';
 
 import { LoadingDots } from '@kubev2v/common';

diff --git a/...orklift-console-plugin/src/modules/Providers/views/migrate/components/PlansUpdateForm.tsx b/...orklift-console-plugin/src/modules/Providers/views/migrate/components/PlansUpdateForm.tsx
@@ -1,7 +1,6 @@
 import React, { ReactNode } from 'react';
 import { FilterableSelect } from 'src/components';
 import SectionHeading from 'src/components/headers/SectionHeading';
-import { PlanEditAction } from 'src/modules/Plans/utils/types/PlanEditAction';
 import { PlanMappingsInitSection } from 'src/modules/Plans/views/details/tabs/Mappings/PlanMappings';
 import { PlanMappingsSectionState } from 'src/modules/Plans/views/details/tabs/Mappings/PlanMappingsSection';
 import { useForkliftTranslation } from 'src/utils/i18n';