Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1935] Add ESLint rule for ignoring unused params with prefix underscore #1441

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Jan 22, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (13484d0) to head (86bb03b).
Report is 188 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.62%     
==========================================
  Files         158      159       +1     
  Lines        2548     2580      +32     
  Branches      599      616      +17     
==========================================
- Hits          938      934       -4     
- Misses       1428     1631     +203     
+ Partials      182       15     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgratch sgratch merged commit 460d2b8 into kubev2v:main Jan 23, 2025
10 of 11 checks passed
@sgratch sgratch deleted the add-typescript-eslint-rule-for-ignoring-unused-params-with-prefix-underscore branch January 23, 2025 09:12
@metalice
Copy link
Collaborator

why warn and not error? @sgratch

@sgratch
Copy link
Collaborator Author

sgratch commented Jan 23, 2025

why warn and not error? @sgratch

Unused arguments were marked as warning before this fix as well, so I didn't want to change the error level.
Can be changed easily to error if we decide so, since there aren't such unused args in the code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants