Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1686] Simplify/update migration plan status cell (part 2) #1442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 22, 2025

📝 Links

References:
MTV-1686
Design issue: HPUX-201
Initial PR (part 1): #1411

Implementation criteria gathered from this design doc: https://docs.google.com/document/d/18HeL1gbw9_q_aLWg39f-kvt7q4rjXlsjTKuMCdZBHQQ/edit?tab=t.0#heading=h.i7p5ubi780ve.

📝 Description

This PR updates the terminology used within the plan migration status cell, updates the filter accordingly for the table, and updates some styling within the cell so that alignment matches the design screenshots seen in the document referenced above.

  • Added unit tests covering scenarios involved with the plan migration status cell.
  • Also added ability to read interpolations for unit tests using translated strings.

🎥 Demo

Screen.Recording.2025-01-22.at.2.20.29.PM.mov

📝 CC://

@heyethankim

@jpuzz0 jpuzz0 added the enhancement Categorizes issue or PR as related to a new feature. label Jan 22, 2025
@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from ba019b8 to 7a7bfc2 Compare January 22, 2025 19:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.50289% with 32 lines in your changes missing coverage. Please review.

Project coverage is 35.71%. Comparing base (13484d0) to head (acb6a1c).
Report is 188 commits behind head on main.

Files with missing lines Patch % Lines
...modules/Plans/actions/PlanActionsDropdownItems.tsx 3.70% 26 Missing ⚠️
...rc/modules/Plans/views/list/components/VMsCell.tsx 0.00% 3 Missing ⚠️
...odules/Plans/utils/helpers/getPlanSummaryStatus.ts 94.11% 2 Missing ⚠️
.../list/components/PlanStatusCell/PlanStatusCell.tsx 94.44% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   36.81%   35.71%   -1.10%     
==========================================
  Files         158      545     +387     
  Lines        2548     9517    +6969     
  Branches      599     2166    +1567     
==========================================
+ Hits          938     3399    +2461     
- Misses       1428     6116    +4688     
+ Partials      182        2     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from 7a7bfc2 to acb6a1c Compare January 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants