Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1948] Plan wizard 2nd step 'create migration' button is disabled without a reason #1445

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 27, 2025

📝 Links

References: https://issues.redhat.com/browse/MTV-1948

📝 Description

Removing Plan name validation check on the 2nd step of the create migration wizard since that now lives on step 1.

🎥 Demo

Screen.Recording.2025-01-27.at.9.24.10.AM.mov

@jpuzz0 jpuzz0 requested a review from sgratch January 27, 2025 14:25
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.11%. Comparing base (13484d0) to head (8b3884d).
Report is 203 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
- Coverage   36.81%   36.11%   -0.70%     
==========================================
  Files         158      159       +1     
  Lines        2548     2586      +38     
  Branches      599      616      +17     
==========================================
- Hits          938      934       -4     
- Misses       1428     1457      +29     
- Partials      182      195      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sgratch sgratch merged commit 9d89766 into kubev2v:main Jan 27, 2025
11 checks passed
@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Jan 27, 2025
@sgratch sgratch added this to the 2.8.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants