Add initial documentation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
reviewed
Aug 16, 2022
mnecas
reviewed
Aug 16, 2022
README.md
Outdated
|
|
||
| ### Start forklift operator server without authentication: | ||
|
|
||
| Start the [forklift-operator](https://github.com/konveyor/forklift-controller) inventory server on `http://localhost:8080` withut authentication. |
There was a problem hiding this comment.
removed the start forklift section
mnecas
reviewed
Aug 16, 2022
README.md
Outdated
Comment on lines
24
to
25
| 1. `oc login` (requires [oc](https://console.redhat.com/openshift/downloads) and an [OpenShift cluster](https://console.redhat.com/openshift/create)) | ||
| 2. `AUTH_REQUIRED=false make run` |
There was a problem hiding this comment.
This will not work with OpenShift cluster but with the minikube and even with it we need some extra steps like kubev2v/forklift-operator#239
There was a problem hiding this comment.
removed this section from the readme
Closed
yaacov
force-pushed
the
add-initial-documentation
branch
2 times, most recently
from
90aae28 to
d52e34c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 8
Branches ? 0
========================================
Hits ? 8
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yaacov
force-pushed
the
add-initial-documentation
branch
2 times, most recently
from
d404699 to
f899039
Compare
yaacov
force-pushed
the
add-initial-documentation
branch
from
f899039 to
7724398
Compare
rszwajko
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate the projects README file, and add a docs directory.