Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the filter dynamically based on available data #777

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Nov 8, 2023

Before, filter definition was static and could only use data known at compile time i.e. constant enums.
With this change the framework is extended to create filters dynamically based on current data. The main use case is to filter items based on data unknown at the compile time i.e. host names.

Example usage:
Screenshot from 2023-11-08 20-06-01
Screenshot from 2023-11-08 20-06-12

Before, filter definition was static and could only use data known at
compile time i.e. constant enums.
With this change the framework is extended to create filters dynamically
based on current data. The main use case is to filter items based on
data unknown at the compile time i.e. host names.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rszwajko rszwajko requested review from yaacov, sjd78 and sgratch November 8, 2023 19:36
@rszwajko rszwajko marked this pull request as ready for review November 8, 2023 19:41
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,
a. I will make an issue for this feature
b. looking at this feature, it will also be nice to have an auto complete feature in the text input, ( the idea is that when you select filter by labels, the user can start typing and will be offered all the dynamically fetched labels that match what they are typing )

@rszwajko
Copy link
Contributor Author

@yaacov

b. looking at this feature, it will also be nice to have an auto complete feature in the text input, ( the idea is that when you select filter by labels, the user can start typing and will be offered all the dynamically fetched labels that match what they are typing )

Implemented in follow-up #779

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for storybook

@yaacov yaacov merged commit 34ee0d0 into kubev2v:main Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants