-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI documentation references links #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As disccused offline, the links will be changed, once we agree on the best way to do it, and after doc team will have docs for 2.6, until then we will use the downstream docs
Reference: kubev2v#781 Update all UI documentation fields help text references links by pointing to the HELP_LINK_HREF and by adding DOCUMENTATION_VERSION as an internal paramter. So that it will be cofigurable for next version bumps. The doc link is pointed to either u/s or d/s doc, based on the BRAND_TYPE env. variable. This is currently relevant for both providers details tab and overview settings card. Signed-off-by: Sharon Gratch <[email protected]>
bb82937
to
b55b02c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The current status, before this fix, is that we use u/s docs on few places that points to a broken link (e.g., empty state msgs) and u/s docs on other places which points to 2.4 instead of 2.5. |
we will fix the upstream docs once the doc team will create some, AFAIK forklift project does not have upstream docs yet.
we are currently working on 2.6, once the 2.6 docs will be ready, we will need to collaborate with release and docs teams to come up with a release mechanism / automation to manage the links in collaboration with all stake holders, e.g. dev that set up the links, docs that publish the docs and release that set up the downstream package so when we release 2.6 the docs will be as up to date as possible cc:// @ahadas @RichardHoch - cc because we currently don't have any automation/manual-flow to update the docs links once they are published by the docs team for specific downstream version, we will need to agree on some flow and then try to automate it, see: #781 . |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
@anarnold97 Would appreciate your insights. |
remove label/ stale |
closing in favor of: |
Reference: #781
Update all UI documentation fields help text references links by pointing to
HELP_LINK_HREF
and by addingDOCUMENTATION_VERSION
as an internal parameter. So that it will be configurable for next version bumps. The doc link is pointed to either u/s or d/s doc, based on theBRAND_TYPE
env. variable.This is currently relevant for both providers details tab and overview settings card.