Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI documentation references links #782

Closed
wants to merge 1 commit into from

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Nov 13, 2023

Reference: #781

Update all UI documentation fields help text references links by pointing to HELP_LINK_HREF and by adding DOCUMENTATION_VERSION as an internal parameter. So that it will be configurable for next version bumps. The doc link is pointed to either u/s or d/s doc, based on the BRAND_TYPE env. variable.

This is currently relevant for both providers details tab and overview settings card.

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As disccused offline, the links will be changed, once we agree on the best way to do it, and after doc team will have docs for 2.6, until then we will use the downstream docs

Reference: kubev2v#781

Update all UI documentation fields help text references links by pointing to the
HELP_LINK_HREF and by adding DOCUMENTATION_VERSION as an internal paramter.
So that it will be cofigurable for next version bumps.
The doc link is pointed to either u/s or d/s doc, based on the BRAND_TYPE
env. variable.

This is currently relevant for both providers details tab and overview
settings card.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch force-pushed the add-doc-param-and-fix-doc-refs branch from bb82937 to b55b02c Compare November 13, 2023 19:33
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@sgratch sgratch changed the title Update UI documentation references links and fix provider details type text Update UI documentation references links Nov 13, 2023
@sgratch
Copy link
Collaborator Author

sgratch commented Nov 13, 2023

As disccused offline, the links will be changed, once we agree on the best way to do it, and after doc team will have docs for 2.6, until then we will use the downstream docs

The current status, before this fix, is that we use u/s docs on few places that points to a broken link (e.g., empty state msgs) and u/s docs on other places which points to 2.4 instead of 2.5.
If not important to fix to 2.5.x, it can wait to the new 2.6 docs of course

@sgratch sgratch requested a review from rszwajko November 13, 2023 19:44
@yaacov
Copy link
Member

yaacov commented Nov 14, 2023

is that we use u/s docs on few places that points to a broken link

we will fix the upstream docs once the doc team will create some, AFAIK forklift project does not have upstream docs yet.

on other places which points to 2.4 instead of 2.5.

we are currently working on 2.6, once the 2.6 docs will be ready, we will need to collaborate with release and docs teams to come up with a release mechanism / automation to manage the links in collaboration with all stake holders, e.g. dev that set up the links, docs that publish the docs and release that set up the downstream package so when we release 2.6 the docs will be as up to date as possible

cc:// @ahadas @RichardHoch - cc because we currently don't have any automation/manual-flow to update the docs links once they are published by the docs team for specific downstream version, we will need to agree on some flow and then try to automate it, see: #781 .

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Dec 15, 2023
@RichardHoch
Copy link

@anarnold97 Would appreciate your insights.

@RichardHoch
Copy link

remove label/ stale

@yaacov
Copy link
Member

yaacov commented Jan 8, 2024

closing in favor of:
#817

@yaacov yaacov closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants