Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user-auth to disabled, default in newer images is now openshift #786

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 23, 2023

Issue:
the user-auth command line argument has default value of "openshift" in some quay.io/openshift/origin-console images.

Fix:
instead of assuming default value is "disabled" set the user-auth manually to "disabled"

@yaacov yaacov requested review from sgratch and rszwajko November 23, 2023 09:19
@yaacov yaacov added this to the 2.6.0 milestone Nov 23, 2023
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 23, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit b812f8e into kubev2v:main Nov 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant