MTV-1433 UI plans by provider #585

RichardHoch · 2024-11-14T14:25:02Z

MTV 2.8

Partially resolves https://issues.redhat.com/browse/MTV-1433

Previews:

https://file.corp.redhat.com/rhoch/ui_plans_by_provider/html-single/#migrating-vmware-ui [VMware section]
https://file.corp.redhat.com/rhoch/ui_plans_by_provider/html-single/#migrating_virtual_machines_from_red_hat_virtualization [RHV section]
https://file.corp.redhat.com/rhoch/ui_plans_by_provider/html-single/#migrating_virtual_machines_from_openstack [OpenStack]
https://file.corp.redhat.com/rhoch/ui_plans_by_provider/html-single/#migrating_virtual_machines_from_ova [OVA]
https://file.corp.redhat.com/rhoch/ui_plans_by_provider/html-single/#migrating_virtual_machines_from_openshift_virtualization [CNV]

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc

documentation/modules/creating-migration-plan-2-8.adoc

RichardHoch · 2024-11-28T14:54:35Z

@sgratch @mnecas Please review this PR.

fabiand

Textual changes lgtm.

For the reordering a preview with all pending PRs would be appreciated.

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc

sgratch

@RichardHoch Few comments

sgratch · 2025-01-20T12:03:30Z

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc

-* {virt}
-
-You can add a source provider by using the {ocp} web console.
+* Remote {virt} clusters


AFAIK, migration can also be from a local ocp provider (to a remote one).
So a source OCP provider can be either local or remote.
@mnecas @fabiand please confirm

sgratch · 2025-01-20T12:26:23Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+ifdef::vmware[]
+
+. Check the following items related to VMware. All are optional except for *Warm migration*.


Following comments are relevant for all providers:

"All are optional except for.." - WDYM by a non optional settings? It's a bit confusing since all options, including this setting, have a default value. So if not set by the user, a default cold value is used. A non optional setting is usually something that the user have to set for proceeding and include a red small asterisk next to it, e.g. plan name

"Transfer Network" and "Target namepsace" settings are not detailed here. Is it in purpose?

Creating a plan via the plan wizard can be done also by going to Provider -> VMs tab, selecting VM(s) => and clicking the "Create migration plan" button. Is it mentioned anywhere?

Signed-off-by: RichardHoch <[email protected]>

RichardHoch · 2025-01-22T16:03:57Z

@sgratch I made the changes we talked about. Please review the PR again. Thanks.

anarnold97 · 2025-02-09T11:08:10Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+[WARNING]
+====
+Do not include virtual machines with guest initiated storage connections, such as Internet Small Computer Systems Interface (iSCSI) connections or Network File System (NFS) mounts. These require either additional planning before a migration or reconfiguration after the migration


Suggested change

Do not include virtual machines with guest initiated storage connections, such as Internet Small Computer Systems Interface (iSCSI) connections or Network File System (NFS) mounts. These require either additional planning before a migration or reconfiguration after the migration

Do not include virtual machines with guest-initiated storage connections, such as Internet Small Computer Systems Interface (iSCSI) connections or Network File System (NFS) mounts. These require either additional planning before migration or reconfiguration after the migration.

anarnold97 · 2025-02-09T11:10:05Z

documentation/modules/creating-migration-plan-2-8.adoc

+> To add either a *Network map* or a *Storage map*, click the *+* sign anf add a mapping.
+. Click *Create migration plan*.
+
+{project-short} validates the migration plan and the *Plan details* page opens, indicating whether the plan is ready for use or contains an error.


Suggested change

{project-short} validates the migration plan and the *Plan details* page opens, indicating whether the plan is ready for use or contains an error.

{project-short} validates the migration plan, and the *Plan details* page opens, indicating whether the plan is ready for use or contains an error.

Conjunction joining two independent clauses means you need to use a comma

anarnold97 · 2025-02-09T11:12:06Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+ifdef::vmware[]
+
+* *Warm migration*: By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.


Suggested change

* *Warm migration*: By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.

* *Warm migration*: By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon and select *Warm migration*.

Not two independent clauses, so you do not need to use a comma

anarnold97 · 2025-02-09T11:15:40Z

documentation/modules/creating-migration-plan-2-8.adoc

+ifdef::vmware[]
+
+* *Warm migration*: By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...


Suggested change

* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...

* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...

Please clarify here. I am unsure as to your usage of the ellipses
Should they be ... or should they be something else? I would certainly add a space between them and the preceding word.

anarnold97 · 2025-02-09T11:17:10Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+* *Warm migration*: By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...
+* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...


Suggested change

* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

* *Target namespace*: Destination namespace, by default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

Same as previous comment and the ellipses

anarnold97 · 2025-02-09T11:18:43Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+* *Specifying a root device*: Applies to multi-boot VM migrations only. By default, {project-short} uses the first bootable device detected as the root device.
+
+To specify a different root device, in the *Settings* section, click the *Edit* icon next to *Root device* and choose a device from the list of commonly-used options, or enter a device in the text box.


it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.

https://www.merriam-webster.com/grammar/6-common-hypercorrections-and-how-to-avoid-them

anarnold97 · 2025-02-09T11:21:42Z

documentation/modules/creating-migration-plan-2-8.adoc

+
+* *Warm migration* By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...
+* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...


Suggested change

* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

* *Target namespace*: Destination namespace, by default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

Again, clarify the ellipses

anarnold97 · 2025-02-09T11:23:09Z

documentation/modules/creating-migration-plan-2-8.adoc

+endif::[]
+
+ifdef::ostack,ova,cnv[]
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...


Clarify ellipses

anarnold97 · 2025-02-09T11:23:56Z

documentation/modules/creating-migration-plan-2-8.adoc

+ifdef::rhv[]
+
+* *Warm migration* By default, all migrations are cold migrations. For a warm migration, click the *Edit* icon, and select *Warm migration*.
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...


Clarify ellipses

anarnold97 · 2025-02-09T11:24:33Z

documentation/modules/creating-migration-plan-2-8.adoc

+ifdef::ostack,ova,cnv[]
+* *Transfer Network*: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the *Edit* icon and...
+
+* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...


Suggested change

* *Target namespace*: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

* *Target namespace*: Destination namespace, by default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the *Edit* icon and...

Clarify ellipses

RichardHoch force-pushed the ui_plans_by_provider branch from f444cad to c891037 Compare November 18, 2024 11:24

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/modules/creating-migration-plan-2-8.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/modules/creating-migration-plan-2-8.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/modules/creating-migration-plan-2-8.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/modules/creating-migration-plan-2-8.adoc Outdated Show resolved Hide resolved

nunzy1 reviewed Nov 21, 2024

View reviewed changes

documentation/modules/creating-migration-plan-2-8.adoc Outdated Show resolved Hide resolved

RichardHoch force-pushed the ui_plans_by_provider branch from c891037 to 6803266 Compare November 24, 2024 09:00

RichardHoch changed the title ~~UI plans by provider~~ MTV-1433 UI plans by provider Nov 24, 2024

RichardHoch mentioned this pull request Nov 27, 2024

MTV-1433: Creating source and destination providers, separated by provider #567

Open

RichardHoch requested review from sgratch and mnecas November 28, 2024 14:57

RichardHoch force-pushed the ui_plans_by_provider branch from 37e186f to cbd8688 Compare December 2, 2024 09:53

fabiand approved these changes Jan 10, 2025

View reviewed changes

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc Show resolved Hide resolved

sgratch reviewed Jan 20, 2025

View reviewed changes

RichardHoch added 9 commits January 20, 2025 16:05

start

8322e70

Signed-off-by: RichardHoch <[email protected]>

Creating migration plans per provider

39cdd0e

Signed-off-by: RichardHoch <[email protected]>

Changed optional steps to INPORTANT notes, rather than sub-steps

66f5d03

Signed-off-by: RichardHoch <[email protected]>

formatting

536d874

Signed-off-by: RichardHoch <[email protected]>

after Nunzy

3980cf4

after Nunzy

6014f5d

from Shruti

a45834e

Changed warning after Nunzy and Fabian

d350167

Adding warm/cold migration option

b5579df

RichardHoch force-pushed the ui_plans_by_provider branch from d73d6b7 to b5579df Compare January 20, 2025 14:05

RichardHoch added 3 commits January 21, 2025 10:01

Sharon partial

1ea90b0

after Sharon

66a3db9

after Sharon

6ffb335

anarnold97 reviewed Feb 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTV-1433 UI plans by provider #585

MTV-1433 UI plans by provider #585

RichardHoch commented Nov 14, 2024 •

edited

Loading

RichardHoch commented Nov 28, 2024

fabiand left a comment

sgratch left a comment

sgratch Jan 20, 2025 •

edited

Loading

sgratch Jan 20, 2025

RichardHoch commented Jan 22, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025

anarnold97 Feb 9, 2025


		ifdef::vmware[]

		. Check the following items related to VMware. All are optional except for Warm migration.

	Do not include virtual machines with guest initiated storage connections, such as Internet Small Computer Systems Interface (iSCSI) connections or Network File System (NFS) mounts. These require either additional planning before a migration or reconfiguration after the migration
	Do not include virtual machines with guest-initiated storage connections, such as Internet Small Computer Systems Interface (iSCSI) connections or Network File System (NFS) mounts. These require either additional planning before migration or reconfiguration after the migration.

	{project-short} validates the migration plan and the Plan details page opens, indicating whether the plan is ready for use or contains an error.
	{project-short} validates the migration plan, and the Plan details page opens, indicating whether the plan is ready for use or contains an error.


		ifdef::vmware[]

		* Warm migration: By default, all migrations are cold migrations. For a warm migration, click the Edit icon, and select Warm migration.

	* Transfer Network: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the Edit icon and...
	* Transfer Network: The network used to transfer the VMs to {virt}. By default... To edit the transfer network, click the Edit icon and...

	* Target namespace: Destination namespace, By default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the Edit icon and...
	* Target namespace: Destination namespace, by default, this is the {virt} cluster you chose as your destination provider. To edit the namespace, click the Edit icon and...

MTV-1433 UI plans by provider #585

Are you sure you want to change the base?

MTV-1433 UI plans by provider #585

Conversation

RichardHoch commented Nov 14, 2024 • edited Loading

RichardHoch commented Nov 28, 2024

fabiand left a comment

Choose a reason for hiding this comment

sgratch left a comment

Choose a reason for hiding this comment

sgratch Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RichardHoch commented Jan 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RichardHoch commented Nov 14, 2024 •

edited

Loading

sgratch Jan 20, 2025 •

edited

Loading