MTV-1536 | Use CDI for disk transfer in cold migration feature toggle #1171
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 15.71% 15.66% -0.05%
==========================================
Files 112 112
Lines 23052 23052
==========================================
- Hits 3623 3612 -11
- Misses 19142 19155 +13
+ Partials 287 285 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
100% thanks! |
pkg/apis/forklift/v1beta1/plan.go
Outdated
| switch source.Type() { | ||
| case VSphere: | ||
| return !p.Spec.Warm && destination.IsHost(), nil | ||
| return !p.Spec.Warm && destination.IsHost() && !useCdiForColdMigration, nil |
There was a problem hiding this comment.
LGTM, I have concerns about the naming and the comments
a. the default now is to use CDI, virt v2v transport is the exception, so useCdiForColdMigration checks if use the default settings, maybe we should check for the exception case useVirtV2vTransport , it will be easier to remove once we fill safe about using CDI and remove the virt v2v transport , WDYT ?
b. another concern is about the name VSphereColdLocal it now checks for 'ova' or 'cold + local + "exception for using virt v2v"' so the name + comment may need to change ?
There was a problem hiding this comment.
Thanks good point, posted latest patch ptal
Issue: This is alternative to kubev2v#1109 which removes the virt-v2v disk transfer and replaces it with te CDI. The main dissadvatage of that solution is that in case customer will have problems with the new CDI method there won't be any easy way how to go back, to the virt-v2v. Fix: This change adds a new feature toggle `feature_vsphere_cold_cdi` in the forklift controller. By default the feature will be enabled and in case there will be problems such as disk corruption the user can disable it. Signed-off-by: Martin Necas <[email protected]>
|
Issue:
This is alternative to #1109 which removes the virt-v2v disk transfer and replaces it with te CDI. The main dissadvatage of that solution is that in case customer will have problems with the new CDI method there won't be any easy way how to go back, to the virt-v2v.
Fix:
This change adds a new feature toggle
feature_vsphere_cold_cdiin the forklift controller. By default the feature will be enabled and in case there will be problems such as disk corruption the user can disable it.