MTV 1595 | PVC name template

[yaacov]

Ref: https://issues.redhat.com/browse/MTV-1595

Issue:
Users operating automation want the capability to know the disk names in the OS in the yamls for the PVC's so they can easily know which PVC is liked to specific volume in a VM.

Fix:
Adding pvcNameTemplate field to the Plan CR and to each VM in the VM list of the plan.

PVCNameTemplate is a template for generating PVC names for VM disks.
The VM specific template will override the template set in the plan.

It follows Go template syntax and has access to the following variables:
 - .VmName: name of the VM
 - .PlanName: name of the migration plan
 - .DiskIndex: initial volume index of the disk
 - .RootDiskIndex: index of the root disk
  
Examples:
   "{{.VmName}}-disk-{{.DiskIndex}}"
   "{{if eq .DiskIndex .RootDiskIndex}}root{{else}}data{{end}}-{{.DiskIndex}}"

In the plan YAML:

spec:
   ...
   pvcNameTemplate:   "{{.VmName}}-disk-{{.DiskIndex}}"

   vms:
    - name: some-vm
      pvcNameTemplate:   "{{.VmName}}-disk-{{.DiskIndex}}"

Screenshots:
pvcNameTemplate fields:

Running plan with custom PVC name:

[yaacov]

@RichardHoch hi, can you have a look at the descriptions ?

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.65041% with 73 lines in your changes missing coverage. Please review.

Project coverage is 15.61%. Comparing base (f1fe5d0) to head (e0baa22).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/plan/adapter/vsphere/builder.go	0.00%	55 Missing ⚠️
pkg/controller/plan/validation.go	73.52%	18 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
+ Coverage   15.45%   15.61%   +0.16%     
==========================================
  Files         112      112              
  Lines       23377    23511     +134     
==========================================
+ Hits         3613     3672      +59     
- Misses      19479    19551      +72     
- Partials      285      288       +3     

Flag	Coverage Δ
unittests	15.61% <40.65%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yaacov]

@mnecas your suggestions worked, build pass now 🎉

[mnecas]

Why do we need the annotation? Can't we get the information directly form CR?

[yaacov]

yes, we can ... woo, will change and ping here ...

[yaacov]

updated the code

[yaacov]

@mnecas hi, I refactored the PR to play nice with #1327
all new changes are in a new commit

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud