MTV-1929 Clean up unused active source connections.

[mrnold]

Fix for MTV-1929, cleans up most active source connections when they are done with their work.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.44%. Comparing base (f1fe5d0) to head (02ae5f9).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/plan/migration.go	0.00%	12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   15.45%   15.44%   -0.01%     
==========================================
  Files         112      112              
  Lines       23377    23389      +12     
==========================================
  Hits         3613     3613              
- Misses      19479    19491      +12     
  Partials      285      285              

Flag	Coverage Δ
unittests	15.44% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mrnold]

This isn't as effective as I hoped, I still see a bunch of idle connections. Maybe I missed one somewhere.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mrnold]

This isn't as effective as I hoped, I still see a bunch of idle connections. Maybe I missed one somewhere.

I moved the logouts into migration.go and it works much better now. I don't see any lingering connections from the same client creation, just one from the collector that isn't quite as obvious to fix.