Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECOPROJECT-2579: Changes behavior when we have source 'Waiting for credentials' #83

Merged

Conversation

ammont82
Copy link
Collaborator

Related with https://issues.redhat.com/browse/ECOPROJECT-2579

This should be the expected behavior:

  • the message should appear below the table right above the next button
  • when selecting an environment that we don't need credentials for this should not appear
  • when deleting an environment, the message should disappear
  • I like the idea of adding the link to the tooltip as well.

Video with the new behavior:

delete_waiting_for_credentials.mp4

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ammont82 ammont82 merged commit 7989fea into kubev2v:main Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants