Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client-path parameter, and make the set token call vm specific #4

Merged
merged 1 commit into from
May 30, 2024

Conversation

yaacov
Copy link
Contributor

@yaacov yaacov commented May 30, 2024

Issue:
Currently a user need to specify the VNC client path and virtual machine full API URL
The VNC path is static and can be specified when starting the proxy
The virtual machine full API URL can be calculated from the vm name and namespace

What this PR do:

Breaking changes:

  • proxy will no longer accept then argument
  • proxy will look for vm name and namespace arguments

Example:

Deprecated:

signed_link="${proxyurl}/auth/jwt/set?token=${jwt}&then=/noVNC/vnc_lite.html?path=k8s${path}"
google-chrome "${signed_link}"

New format:

signed_link="${proxyurl}/auth/jwt/set?token=${jwt}&name=${vmname}&namespace=${vmnamespace}"
google-chrome "${signed_link}"

Running the CLI proxy:

./kube-gateway --help
  ...
  -client-path string
    	url endpoint for user client calls. (default "/noVNC/vnc_lite.html")
  ...
./kube-gateway -client-path  "/noVNC/vnc_lite.html"

Changes:

  • Remove the then URL search argument from the proxy server arguments
  • Add virtual machine name and namespace to the URL search argument from the proxy server arguments
  • Add a -client-path CLI argument to kube-gateway CLI application
  • Add -client-path CLI argument value to the example kuebernetes yaml deployment file
  • Update base container image from ubi8/ubi-minimal to ubi9/ubi-minimal
  • Update readme to use virtual machine name and namespace, instead of API path

@yaacov yaacov merged commit 3e7e804 into main May 30, 2024
1 check passed
@yaacov yaacov deleted the make-client-path-static branch May 30, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant