Add a client-path parameter, and make the set token call vm specific #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently a user need to specify the VNC client path and virtual machine full API URL
The VNC path is static and can be specified when starting the proxy
The virtual machine full API URL can be calculated from the vm name and namespace
What this PR do:
Breaking changes:
then
argumentname
andnamespace
argumentsExample:
Deprecated:
New format:
Running the CLI proxy:
./kube-gateway -client-path "/noVNC/vnc_lite.html"
Changes:
then
URL search argument from the proxy server arguments-client-path
CLI argument to kube-gateway CLI application-client-path
CLI argument value to the example kuebernetes yaml deployment file